840641 - Large Shield Icon Missing in Mixed Content Blocker Doorhanger

Status: VERIFIED FIXED

(Firefox :: Security, defect)

Description

[Tanvi Vyas[:tanvi]]

The shield icon from the drop down doorhanger is missing on linux and windows.

I need the icons and then I can add them to pinstripe and gnomestripe.

https://bug822371.bugzilla.mozilla.org/attachment.cgi?id=709396

+++ This bug was initially created as a clone of Bug #822371 +++

Implement the frontend UI for the Drop down Doorhanger when Mixed Active Content is Blocked.

Comment 1

[Tanvi Vyas[:tanvi]]

(In reply to Tanvi Vyas [:tanvi] from comment #0)
> The shield icon from the drop down doorhanger is missing on linux and
> windows.
> 
> I need the icons and then I can add them to pinstripe and gnomestripe.
Correction ... this should say that I need the icons for winstripe and gnomestripe.

Comment 2

[Valerio]

Attachment: large shield icon

This is the icon used for pinstripe; maybe it can also be used here

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

This is already blocking bug 834836 - so let's not nominate bug 834836 for approval until all it's dep bugs are fixed including this one.

Comment 4

[Tanvi Vyas[:tanvi]]

Attachment: Shield icon for linux and windows

Updates the following files to include the larger shield icon:

browser/themes/gnomestripe/browser.css
browser/themes/gnomestripe/jar.mn
browser/themes/gnomestripe/mixed-content-blocked-64.png
browser/themes/winstripe/jar.mn
browser/themes/winstripe/mixed-content-blocked-64.png

Note that browser/themes/winstripe/browser.css already has this and hence that file isn't needed in the patch:
http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser.css#2272

Comment 5

[Tanvi Vyas[:tanvi]]

Also, I talked to Stephen and he said using the same image for all 3 (windows, linux, and mac) was fine for now.

Comment 6

[Justin Dolske [:Dolske]]

(Resulting bugs "block" the original bug, aka the original bug "depends" on the resulting bug in order to have a complete fix.)

Comment 7

[Tanvi Vyas[:tanvi]]

Looks good on linux.  Going to push to inbound.

Comment 8

[Tanvi Vyas[:tanvi]]

Attachment: Shield icon for linux and windows v2

Fixed merge issues.  Carrying over r+.

Comment 9

[Tanvi Vyas[:tanvi]]

Pushed to inbound: hg.mozilla.org/integration/mozilla-inbound/rev/26b3586e3af4

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/26b3586e3af4

Comment 11

[Valerio]

I have Windows 7 and Nightly updated to the latest version but the icon still doesn't appear

Comment 12

[Virgil Dicu [:virgil] [QA]]

(In reply to Valerio from comment #11)
> I have Windows 7 and Nightly updated to the latest version but the icon
> still doesn't appear
I can confirm this.
Mozilla/5.0 (Windows NT 6.2; rv:21.0) Gecko/20130220 Firefox/21.0
Mozilla/5.0 (Windows NT 6.2; rv:22.0) Gecko/20130220 Firefox/22.0
Logged bug 843540 for that.

Verified that this works correctly on Linux (Ubuntu) and Mac OS on both Aurora and Nightly.

I'll set this to verified, because it fixes the Linux issue and we'll have bug 843540  open for the Windows issue.