[Windows] Shield icon missing in Mixed content blocker doorhanger

VERIFIED FIXED in Firefox 22

Status

()

Firefox
Security
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: virgil, Assigned: tanvi)

Tracking

(Blocks: 1 bug)

21 Branch
Firefox 22
All
Windows 8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox21- affected)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 716481 [details]
Shield icon mmissing on Windows

Mozilla/5.0 (Windows NT 6.2; rv:21.0) Gecko/20130220 Firefox/21.0
Mozilla/5.0 (Windows NT 6.2; rv:22.0) Gecko/20130220 Firefox/22.0

Bug 840641 fixed the Linux issue, but the icon is still missing on Windows.
(Reporter)

Updated

5 years ago
Blocks: 840641
(Assignee)

Updated

5 years ago
Blocks: 815321
No longer blocks: 840641
It looks like it is missing a reference for aero in the jar.mn file.
(Assignee)

Comment 3

5 years ago
Created attachment 716692 [details] [diff] [review]
Add shield icon to aero v1

Thanks keeler for the tip.  I'm didn't add the image to skin/classic/aero/browser (what is aero?).  Patch attached.  

Virgil, can you try applying this patch and see if you see the shield on windows?
Assignee: nobody → tanvi
Status: NEW → ASSIGNED
Attachment #716692 - Flags: review?(dolske)
(Assignee)

Comment 4

5 years ago
(In reply to Jared Wein [:jaws] from comment #2)
> It looks like it is missing a reference for aero in the jar.mn file.

Thanks to Jared also!
(In reply to Tanvi Vyas [:tanvi] from comment #3)
> I'm didn't add the image to
> skin/classic/aero/browser (what is aero?).

Aero is the theme customization for Windows Vista and Windows 7 when Aero glass is enabled.
Comment on attachment 716692 [details] [diff] [review]
Add shield icon to aero v1

Crap. I should have noticed that in the previous bug's review, sorry.
Attachment #716692 - Flags: review?(dolske) → review+
(Reporter)

Comment 7

5 years ago
(In reply to Tanvi Vyas [:tanvi] from comment #3)
> Virgil, can you try applying this patch and see if you see the shield on
> windows?

If this is still needed, could you provide a try build? Had trouble in the past when building on our machines here on Windows (we usually use Linux)
(Assignee)

Comment 8

5 years ago
Pushed to inbound: hg.mozilla.org/integration/mozilla-inbound/rev/5a070d16268d

Virgil, I think it's okay.  After it moves to central, we can check it on windows 7 / metro before marking it resolved fixed.

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/5a070d16268d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
(Reporter)

Comment 10

5 years ago
Mozilla/5.0 (Windows NT 6.2; rv:22.0) Gecko/20130224 Firefox/22.0

Looks good on all Windows platforms: checked Windows 8, Vista, Windows 7 (different themes) and XP.
Metro doesn't currently have the security UI implemented completely, so this can't be verified there.
Status: RESOLVED → VERIFIED

Comment 11

5 years ago
It would be possible to backport this icon in Aurora for not having the mixed content blocker popup without it?
status-firefox21: --- → affected
tracking-firefox21: --- → ?
Similar to bug 840641, we won't approve bug 834836 for uplift until blockers have been resolved on 21. Feel free to nominate for uplift, however.
tracking-firefox21: ? → -
You need to log in before you can comment on or make changes to this bug.