Closed Bug 843540 Opened 8 years ago Closed 8 years ago

[Windows] Shield icon missing in Mixed content blocker doorhanger

Categories

(Firefox :: Security, defect)

21 Branch
All
Windows 8
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 22
Tracking Status
firefox21 - affected

People

(Reporter: virgil.dicu, Assigned: tanvi)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Mozilla/5.0 (Windows NT 6.2; rv:21.0) Gecko/20130220 Firefox/21.0
Mozilla/5.0 (Windows NT 6.2; rv:22.0) Gecko/20130220 Firefox/22.0

Bug 840641 fixed the Linux issue, but the icon is still missing on Windows.
Blocks: 840641
Blocks: MixedContentBlocker
No longer blocks: 840641
It looks like it is missing a reference for aero in the jar.mn file.
Thanks keeler for the tip.  I'm didn't add the image to skin/classic/aero/browser (what is aero?).  Patch attached.  

Virgil, can you try applying this patch and see if you see the shield on windows?
Assignee: nobody → tanvi
Status: NEW → ASSIGNED
Attachment #716692 - Flags: review?(dolske)
(In reply to Jared Wein [:jaws] from comment #2)
> It looks like it is missing a reference for aero in the jar.mn file.

Thanks to Jared also!
(In reply to Tanvi Vyas [:tanvi] from comment #3)
> I'm didn't add the image to
> skin/classic/aero/browser (what is aero?).

Aero is the theme customization for Windows Vista and Windows 7 when Aero glass is enabled.
Comment on attachment 716692 [details] [diff] [review]
Add shield icon to aero v1

Crap. I should have noticed that in the previous bug's review, sorry.
Attachment #716692 - Flags: review?(dolske) → review+
(In reply to Tanvi Vyas [:tanvi] from comment #3)
> Virgil, can you try applying this patch and see if you see the shield on
> windows?

If this is still needed, could you provide a try build? Had trouble in the past when building on our machines here on Windows (we usually use Linux)
Pushed to inbound: hg.mozilla.org/integration/mozilla-inbound/rev/5a070d16268d

Virgil, I think it's okay.  After it moves to central, we can check it on windows 7 / metro before marking it resolved fixed.
https://hg.mozilla.org/mozilla-central/rev/5a070d16268d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Mozilla/5.0 (Windows NT 6.2; rv:22.0) Gecko/20130224 Firefox/22.0

Looks good on all Windows platforms: checked Windows 8, Vista, Windows 7 (different themes) and XP.
Metro doesn't currently have the security UI implemented completely, so this can't be verified there.
Status: RESOLVED → VERIFIED
It would be possible to backport this icon in Aurora for not having the mixed content blocker popup without it?
Similar to bug 840641, we won't approve bug 834836 for uplift until blockers have been resolved on 21. Feel free to nominate for uplift, however.
You need to log in before you can comment on or make changes to this bug.