843540 - [Windows] Shield icon missing in Mixed content blocker doorhanger

Status: VERIFIED FIXED

(Firefox :: Security, defect)

Description

[Virgil Dicu [:virgil] [QA]]

Attachment: Shield icon mmissing on Windows

Mozilla/5.0 (Windows NT 6.2; rv:21.0) Gecko/20130220 Firefox/21.0
Mozilla/5.0 (Windows NT 6.2; rv:22.0) Gecko/20130220 Firefox/22.0

Bug 840641 fixed the Linux issue, but the icon is still missing on Windows.

Comment 1

[Tanvi Vyas[:tanvi]]

I'm not sure why it is missing.  Everything seems to be in place and identical on all three platforms:

Linux:
http://mxr.mozilla.org/mozilla-central/source/browser/themes/gnomestripe/browser.css#1215
http://mxr.mozilla.org/mozilla-central/source/browser/themes/gnomestripe/jar.mn#34
http://mxr.mozilla.org/mozilla-central/source/browser/themes/gnomestripe/mixed-content-blocked-64.png

Windows:
http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser.css#2272
http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/jar.mn#42
http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/mixed-content-blocked-64.png

Mac:
https://mxr.mozilla.org/mozilla-central/source/browser/themes/pinstripe/browser.css#3216
https://mxr.mozilla.org/mozilla-central/source/browser/themes/pinstripe/jar.mn#46
https://mxr.mozilla.org/mozilla-central/source/browser/themes/pinstripe/mixed-content-blocked-64.png

Justin or Jared - can you take a look and see if you can figure out what I could be missing?  Thanks!

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

It looks like it is missing a reference for aero in the jar.mn file.

Comment 3

[Tanvi Vyas[:tanvi]]

Attachment: Add shield icon to aero v1

Thanks keeler for the tip.  I'm didn't add the image to skin/classic/aero/browser (what is aero?).  Patch attached.  

Virgil, can you try applying this patch and see if you see the shield on windows?

Comment 4

[Tanvi Vyas[:tanvi]]

(In reply to Jared Wein [:jaws] from comment #2)
> It looks like it is missing a reference for aero in the jar.mn file.

Thanks to Jared also!

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Tanvi Vyas [:tanvi] from comment #3)
> I'm didn't add the image to
> skin/classic/aero/browser (what is aero?).

Aero is the theme customization for Windows Vista and Windows 7 when Aero glass is enabled.

Comment 6

[Justin Dolske [:Dolske]]

Comment on attachment 716692 [details] [diff] [review]
Add shield icon to aero v1

Crap. I should have noticed that in the previous bug's review, sorry.

Comment 7

[Virgil Dicu [:virgil] [QA]]

(In reply to Tanvi Vyas [:tanvi] from comment #3)
> Virgil, can you try applying this patch and see if you see the shield on
> windows?

If this is still needed, could you provide a try build? Had trouble in the past when building on our machines here on Windows (we usually use Linux)

Comment 8

[Tanvi Vyas[:tanvi]]

Pushed to inbound: hg.mozilla.org/integration/mozilla-inbound/rev/5a070d16268d

Virgil, I think it's okay.  After it moves to central, we can check it on windows 7 / metro before marking it resolved fixed.

Comment 9

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/5a070d16268d

Comment 10

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (Windows NT 6.2; rv:22.0) Gecko/20130224 Firefox/22.0

Looks good on all Windows platforms: checked Windows 8, Vista, Windows 7 (different themes) and XP.
Metro doesn't currently have the security UI implemented completely, so this can't be verified there.

Comment 11

[Valerio]

It would be possible to backport this icon in Aurora for not having the mixed content blocker popup without it?

Comment 12

[Alex Keybl [:akeybl]]

Similar to bug 840641, we won't approve bug 834836 for uplift until blockers have been resolved on 21. Feel free to nominate for uplift, however.