840655 - [DIALER] Tapping the log entry in the call log takes user to a contact information page instead of the call being dialed out.

Status: RESOLVED DUPLICATE of bug 920011

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Mila Davydova]

When user opens a call log in the Dialer app and taps on one of the log entries associated to a previously saved contact, user is taken to selected contact information page instead of the call being dialed out.

Repro Steps: 
1. Update Unagi Phone to build 20130212070205
2. Go to the Dialer app
3. Open call log 
4. Tap on the log entry associated to one of the contacts 

Expected:
A call to the contact selected is performed without any further interaction.

Actual:
After tapping the register in the call log user is taken to the contact info page instead of the call being dialed out.

Notes:
-Repros 100% on multiple unagi devices

-Issue repros in both nightly and Master builds

Nightly build ID 20130212070205
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/3f905f0ca9ce
Gaia  ecca2ee860825547d5e1109436b50b74dfe9261e

Master build ID 2013021031203 
Gaia - 869e16dfdc3
Gecko - 36525224b14e

Comment 1

[Mila Davydova]

Attachment: call log bug 840655

Comment 3

[Evan Tseng [:evanxd]]

Hi Mila,

I think

Comment 4

[Evan Tseng [:evanxd]]

Hi Mila,

I think it's an UX design issue.
I'm checking this with the UX owner of Dialer App.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Josh, who is the UX that handles dialer?

Comment 6

[Casey Yee]

Redirecting to Rob since he is tasked with working on Dialer.

Also CC Ayman for comment.

Comment 7

[Rob MacDonald [:robmac]]

Hi everybody...

This bug is valid. Tapping on the call log entry should initiate a call to the number that's associated with the entry. This is described in Ayman's spec...

https://www.dropbox.com/s/iqu4xchtnn6ryzb/HTML5_Dialer_Contacts_20120810_R2S1_V6.0.pdf
Page 11 point 4 "Upon tap: call the contact using the same phone number that is associated to the selected module".

That said, I propose that we add a long-tap that brings up an option menu with the following items:

For known numbers: "Call", "Open contact", "Send a message", "Remove from call log"

For unknown numbers: "Call", "Create a new contact", "Add to existing contact", "Send a message", "Remove from call log"

Ayman, let me know if you have any thoughts on this.

Comment 8

[Arun Balachandran Ganesan [:abc]]

Rob:

For the long press, I suggest

View contact (instead of *open contact*)
Send message (instead of *send a message*)
Create as new contact/Create new contact (instead of *create a new contact*)

Also, I happen to have accidentally spent time on this today (another bug caused some confusion). 

Here's the source: https://www.dropbox.com/s/6ypamio2vlb1jx7/call-log-long-press.key

It addresses the case for 'unknown numbers' as you have described. You can modify it to as you see fit.

Comment 9

[Dietrich Ayala (:dietrich)]

Easy workaround, so not blocking the 1.1 release, but definitely would take a fix so tracking+.

Comment 10

[Rob MacDonald [:robmac]]

This proposal needs to be reviewed by legal. I'll get this started and post an update to this bug.

Comment 11

[Rob MacDonald [:robmac]]

Adding Francis as the interaction design owner for this component. We will examine this as part of our 1.2 efforts.

Comment 12

[Anthony Ricaud (:rik)]

Rob: Do you have an estimate for the legal review? We'd like to implement this as it's a really annoying user interaction.

Comment 13

[Rob MacDonald [:robmac]]

Hi Anthony - It turns out that we need to explore other options and that's why we decided to look at this as part of our 1.2 concepting, factoring in any design constraints. One option that may be worth exploring is the idea of a dual action control, which isn't part of our current component set. 

Our 1.2 concepting is kicking off now so please flag Francis Djabri or Stephany Wilkes if you have any questions regarding prioritization.

- Rob

Comment 14

[Michał Budzyński (:michalbe)]

Any news on how this bug should be solved?

Comment 15

[Francis Djabri [:djabber]]

Assigning this to myself as I'm now responsible for Phone UX issues.

Comment 16

[Stephany Wilkes]

Cleaning up Bugzilla and reassigning to lucky Jacqueline :) since she is on Dialer now. Jacqueline, we should confirm this issue still exists before addressing it. If it has been superseded by subsequent designs, feel free to resolve it as Invalid.

Comment 17

[Anthony Ricaud (:rik)]

I'm gonna mark this as a duplicate of bug 920011 because it has moztrap and specifications attached to it.