840692 - Use HTTPS instead of HTTP for startup pages (startup.homepage_override_url and startup.homepage_welcome_url)

Status: VERIFIED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

+++ This bug was initially created as a clone of Bug #840687 +++
+++ This bug was initially created as a clone of Bug #771788 +++

startup.homepage_override_url;http://www.mozilla.org/projects/%APP%/%VERSION%/whatsnew/?oldversion=%OLD_VERSION%
startup.homepage_welcome_url;http://www.mozilla.org/projects/%APP%/%VERSION%/firstrun/

Since we force users to load these pages at startup, it is even more important that we use https:// URLs for these than for the other URLs given in bug 840687. At the same time, because we load these pages automatically for everybody, we have to make sure we can support the extra load on the HTTPS site.

CC'ing potch since he's the only webdev whose bugzilla nickname I can remember right now.

Comment 1

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 2

[Raymond Lee [:raymondlee]]

Comment on attachment 720545 [details] [diff] [review]
v1

Will change to use mozilla.org as well

Comment 3

[Raymond Lee [:raymondlee]]

Attachment: v2

Redirect map:
https://www.mozilla.org/firefox/19.0/whatsnew/ -> https://www.mozilla.org/en-US/firefox/19.0/whatsnew/
https://www.mozilla.org/firefox/19.0/firstrun/ -> https://www.mozilla.org/en-US/firefox/19.0/firstrun/
https://www.mozilla.org/en-US/firefox/19.0/whatsnew/ -> no redirect
https://www.mozilla.org/en-US/firefox/19.0/firstrun/ -> no redirect

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Note that this patch conflicts somewhat with bug 486660. We may have to wait to sort that out.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 720568 [details] [diff] [review]
v2

Let's take only the browser/branding/official/pref/firefox-branding.js changes (the other changes will need to be removed to avoid a conflict with bug 486660).

Please also change "%app%" to "firefox", per bug 841221 comment 13.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

nmaul: this will make the pages opened automatically after Firefox updates hit https://mozilla.org instead of http://mozilla.org. I would like to confirm with someone from IT that this is unlikely to cause any trouble. Can you hook me up with the right person to confirm that, if you're not that person?

Comment 7

[Raymond Lee [:raymondlee]]

Attachment: v3

Comment 8

[Raymond Lee [:raymondlee]]

Attachment: Patch for check in

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #6)
> nmaul: this will make the pages opened automatically after Firefox updates
> hit https://mozilla.org instead of http://mozilla.org. I would like to
> confirm with someone from IT that this is unlikely to cause any trouble. Can
> you hook me up with the right person to confirm that, if you're not that
> person?

Lets wait for info about this before landing the patch.

Comment 9

[Jake Maul [:jakem]]

According to attachment 754650 [details] [diff] [review], it looks like we're changing from http://www.mozilla.com to https://www.mozilla.org. That's fine, we already redirect from .com to .org anyway, and https:// certainly works.

No concerns here on that change. In fact it'll make things nicer for us, due to less hits overall (avoiding the redirect).


I think, however, that you might want to check with Metrics on this. I know they keep track of /whatsnew/ and /firstrun/ hits, so it would be good to confirm with them that this is a no-op. I'm suspect it is, due to the aforementioned redirect that's already in place, but it would be good to get an authoritative answer just in case they're actually tracking the .com hit. If they are, they'll need some time to adjust.

Anurag (aphadke in IRC) might be a good contact for that.

Comment 10

[Anurag Phadke[:[e-mail]]]

metrics only collects the zeus logs and pushes the logs to DWH, the above switch doesn't involve any change on metrics side of things.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/164fc337248e

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/164fc337248e

Comment 13

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 and Mac OSX 10.8.5 using latest Nightly 34.0a1.