Closed
Bug 840776
Opened 11 years ago
Closed 11 years ago
Defect - Safe Browsing "Why was the page blocked" button does nothing
Categories
(Tracking Graveyard :: Metro Operations, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: asa, Assigned: TimAbraldes)
References
Details
(Whiteboard: feature=defect c=content_features u=metro_firefox_user p=3 status=verified)
Attachments
(1 file)
1.50 KB,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
Tested 2013-02-12 Elm Nightly build from http://hg.mozilla.org/projects/elm/rev/aac6ba901fea See Story at https://bug801093.bugzilla.mozilla.org/attachment.cgi?id=704738 where we fail step #3 in the Main Success Scenario. The "Why was the page blocked" button was non-functional.
Updated•11 years ago
|
Blocks: metrov1it3
Whiteboard: feature=defect c=content_features u=metro_firefox_user → feature=defect c=content_features u=metro_firefox_user p=0
Updated•11 years ago
|
Assignee: nobody → mmucci
Updated•11 years ago
|
Priority: -- → P1
Updated•11 years ago
|
Updated•11 years ago
|
Assignee: nobody → tabraldes
Whiteboard: feature=defect c=content_features u=metro_firefox_user p=0 → feature=defect c=content_features u=metro_firefox_user p=3
Comment 1•11 years ago
|
||
Note: Some of the code for this lives at: http://hg.mozilla.org/mozilla-central/file/06935f2db267/browser/metro/base/content/contenthandlers/Content.js#l458
Updated•11 years ago
|
Status: NEW → ASSIGNED
Updated•11 years ago
|
Component: General → Metro Operations
Product: Firefox for Metro → Tracking
Version: unspecified → ---
Assignee | ||
Comment 2•11 years ago
|
||
In Content.js, we handle the clicking of the buttons on about:blocked by sending messages to be received by Browser.js. Due to a typo, we were sending an unrecognized message, so the "Why was the page blocked" button didn't do anything. After this patch is applied, clicking the button will take you to a 404 page on Mozilla's site. This is because the app name is part of the URL that we send users to, and mozilla.org doesn't have a page set up for metrofirefox. I'll file a separate bug to get [1] set up as a valid page. http://www.mozilla.org/en-US/metrofirefox/phishing-protection
Attachment #719142 -
Flags: review?(mbrubeck)
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Tim Abraldes (:tabraldes) from comment #2) > Created attachment 719142 [details] [diff] [review] > Patch v1 > > In Content.js, we handle the clicking of the buttons on about:blocked by > sending messages to be received by Browser.js. Due to a typo, we were > sending an unrecognized message, so the "Why was the page blocked" button > didn't do anything. > > After this patch is applied, clicking the button will take you to a 404 page > on Mozilla's site. This is because the app name is part of the URL that we > send users to, and mozilla.org doesn't have a page set up for metrofirefox. > > I'll file a separate bug to get [1] set up as a valid page. > > http://www.mozilla.org/en-US/metrofirefox/phishing-protection Filed bug 845983
Updated•11 years ago
|
Attachment #719142 -
Flags: review?(mbrubeck) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/bc0a94d091db
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bc0a94d091db
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Flags: needinfo?(jbecerra)
Comment 6•11 years ago
|
||
Tested on 2013-02-28 with a nightly build from http://hg.mozilla.org/mozilla-central/rev/c65d59d33aa8 - There are two buttons shown when I go to the test phishing page https://www.mozilla.org/firefox/its-a-trap.html and the two buttons work. - The "why was this page blocked" option takes you to the page in comment #2
Status: RESOLVED → VERIFIED
Flags: needinfo?(jbecerra)
Whiteboard: feature=defect c=content_features u=metro_firefox_user p=3 → feature=defect c=content_features u=metro_firefox_user p=3 status=verified
Comment 7•11 years ago
|
||
User Agent:Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:25.0) Gecko/20130724 Firefox/25.0 Build ID: 20130724030204 WFM. Tested on Windows 8.1 preview for iteration 10 using latest nightly from ftp://ftp.mozilla.org/pub/firefox/nightly/2013/07/2013-07-24-03-02-04-mozilla-central/ I followed user story and got expected result.
Comment 8•11 years ago
|
||
User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0 Build ID: 20130808030205 Built from http://hg.mozilla.org/mozilla-central/rev/fd4cf30428b0 WFM Tested on windows 8 using latest nightly for iteration-11. I followed user story and got expected result.
Comment 9•11 years ago
|
||
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 Build ID: 20130825030201 Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6 WFM Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and got expected result.
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
Updated•5 years ago
|
Product: Tracking → Tracking Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•