840776 - Defect - Safe Browsing "Why was the page blocked" button does nothing

Status: VERIFIED FIXED

(Tracking Graveyard :: Metro Operations, defect, P1)

Description

[Asa Dotzler [:asa]]

Tested 2013-02-12 Elm Nightly build from http://hg.mozilla.org/projects/elm/rev/aac6ba901fea

See Story at https://bug801093.bugzilla.mozilla.org/attachment.cgi?id=704738 where we fail step #3 in the Main Success Scenario. 

The "Why was the page blocked" button was non-functional.

Comment 1

[Matt Brubeck (:mbrubeck)]

Note: Some of the code for this lives at:
http://hg.mozilla.org/mozilla-central/file/06935f2db267/browser/metro/base/content/contenthandlers/Content.js#l458

Comment 2

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: Patch v1

In Content.js, we handle the clicking of the buttons on about:blocked by sending messages to be received by Browser.js.  Due to a typo, we were sending an unrecognized message, so the "Why was the page blocked" button didn't do anything.

After this patch is applied, clicking the button will take you to a 404 page on Mozilla's site.  This is because the app name is part of the URL that we send users to, and mozilla.org doesn't have a page set up for metrofirefox.

I'll file a separate bug to get [1] set up as a valid page.

http://www.mozilla.org/en-US/metrofirefox/phishing-protection

Comment 3

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

(In reply to Tim Abraldes (:tabraldes) from comment #2)
> Created attachment 719142 [details] [diff] [review]
> Patch v1
> 
> In Content.js, we handle the clicking of the buttons on about:blocked by
> sending messages to be received by Browser.js.  Due to a typo, we were
> sending an unrecognized message, so the "Why was the page blocked" button
> didn't do anything.
> 
> After this patch is applied, clicking the button will take you to a 404 page
> on Mozilla's site.  This is because the app name is part of the URL that we
> send users to, and mozilla.org doesn't have a page set up for metrofirefox.
> 
> I'll file a separate bug to get [1] set up as a valid page.
> 
> http://www.mozilla.org/en-US/metrofirefox/phishing-protection

Filed bug 845983

Comment 4

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc0a94d091db

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/bc0a94d091db

Comment 6

[juan becerra [:juanb]]

Tested on 2013-02-28 with a nightly build from http://hg.mozilla.org/mozilla-central/rev/c65d59d33aa8
- There are two buttons shown when I go to the test phishing page https://www.mozilla.org/firefox/its-a-trap.html and the two buttons work.
- The "why was this page blocked" option takes you to the page in comment #2

Comment 7

[Samvedana (:Samvedana)]

User Agent:Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:25.0) Gecko/20130724 Firefox/25.0
Build ID: 20130724030204

WFM.

Tested on Windows 8.1 preview for iteration 10 using latest nightly from ftp://ftp.mozilla.org/pub/firefox/nightly/2013/07/2013-07-24-03-02-04-mozilla-central/

I followed user story and got expected result.

Comment 8

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130808030205
Built from http://hg.mozilla.org/mozilla-central/rev/fd4cf30428b0

WFM
Tested on windows 8 using latest nightly  for iteration-11. I followed user story and got expected result.

Comment 9

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and got expected result.