840833 - Backport sydneyaudio Gonk fixes to sydneyaudio Android

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

Bug 833724 fixes a number of issues in the Gonk backend.  Most of these exist in the Android backend too, so we need to backport the fixes.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: patch v0

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 713243 [details] [diff] [review]
patch v0

Since you've been working on the AudioTrack cubeb backend, you're the best person to review this. :-)

Comment 3

[Paul Adenot (:padenot)]

Comment on attachment 713243 [details] [diff] [review]
patch v0

Review of attachment 713243 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libsydneyaudio/src/sydney_audio_android.c
@@ +332,5 @@
>      p += r;
>      wrote += r;
> +    s->amountWritten += r;
> +
> +    sa_stream_resume(s);

I assume you tested this does not underrun with the current state of things?

I believe people using mozWriteAudio without checking will know when they underrun by watching logcat.

Comment 4

[Matthew Gregan [:kinetik]]

(In reply to Paul Adenot (:padenot) from comment #3)
> I assume you tested this does not underrun with the current state of things?

For regular media playback, the fill-until-short-write mechanism to prefill the buffer was being defeated by the AudioStream being paused and resumed immediately after being created, so there should not no change in behaviour there.  See bug 833724 comment 6.

Comment 5

[Matthew Gregan [:kinetik]]

CCing Chris, just in case landing this causes regressions.

Comment 6

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/17579083472f

Comment 7

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/mozilla-central/rev/17579083472f