840995 - [YOUTUBE] When playing a youtube video, you don´t have any UI to pause, go back, etc.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Carlos Martínez Toral [:carlosmartinez]]

Tested in unagi with Gecko-70c8f2c.Gaia-ecca2ee.

STR:
1-Open browser app
2-Type youtube.com
3-Tap in a video
4-Once video preview is opened, tap in play

Expected result --> Video app is opened to play youtube video. Same UI available for local videos is displayed to pause, go back...

Actual result --> Video app is opened to play youtube video but not UI available to pause, go back...

Comment 1

[Casey Yee]

This seems to work for me.  I get the standard video player app UI with the back button top-left corner of the video.

The one thing that I think we do need to change is to offer the ability for the user to back-out of a loading video.   I get a full black screen with a blue spinner that I can't exit.  This is very much an issue for slow connections.

Comment 2

[Marcia Knous [:marcia]]

This fails for me using the Inari device, so adding keyword. Using

Gecko 
Gaia   ecca2ee860825547d5e1109436b50b74dfe9261e
BuildID 20130211165958
Version 18.0

Comment 3

[Andrew Overholt [:overholt]]

The YouTube app from Everything.me has no controls for me.

Comment 4

[Andrew Overholt [:overholt]]

Triagers would like input from product here.

Comment 5

[Dale Harvey (:daleharvey)]

reproduced this, strange regression, will get it today

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Can't remember what info we wanted from product and since this is a regression of a pretty important feature, we'll go ahead with blocking.

Comment 8

[Dale Harvey (:daleharvey)]

Attachment: Pointer to Github

I missed this regression from a previous review, we knew when we split the video player out into a seperate youtube html file that is would be extremely delicate. 

This fixes the current bug, but we should most definitely get these sharing html and js fairly soon.

Comment 9

[David Flanagan [:djf]]

Comment on attachment 716355 [details]
Pointer to Github

Its a simple CSS patch, and it works for me. r+

This bug is my fault. I'm the one who added the spinner and the code to hide it by setting the hidden class. I think I assumed that the style sheet had .hidden {display:none} defined somewhere.  As far as I can tell, this has been broken since December or whenever I landed my youtube-related patches.  Sorry!

Comment 10

[David Flanagan [:djf]]

Landed in Gaia master: 
https://github.com/mozilla-b2g/gaia/commit/ac45fcadb9e8067b4f24980601447ad8cf8a38c3

Comment 11

[David Flanagan [:djf]]

I've filed a followup bug to address Casey's point in the 2nd paragraph of comment #1. See bug 843664.

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train@a2ccf8e51756b5ad81b34e9d336419444007db9e
v1.0.1@f7f2b36e5d7d8d1f724ee6503160bc6ec09db474

Comment 13

[Mila Davydova]

This issue no longer reproduces on Unagi device.
Build ID: 20130313070202
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/e74dafa6b2d9
Gaia: b34e726147f8e671ad8c538b50900ccfbffcb084

When playing a youtube video, the UI is available for user to pause or go back.
Verified fixed.

Comment 14

[Mila Davydova]

The issue also appears fixed on Unagi build ID: 20130326070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/28b048ffb7a7
Gaia: ace1eb32a313da1232bbdf9cff2581a4b036356d