843664 - For view activity, show back button even when spinner is spinning

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[David Flanagan [:djf]]

This bug is to address Casey's comment on separate bug: https://bugzilla.mozilla.org/show_bug.cgi?id=840995#c1

Currently, the when the video app is invoked by activity to play a youtube video it displays a spinner animation while it talks to the youtube server to find a version of the video it can play.  But it doesn't display a back button while it is doing that, so on a slow connection, the user is trapped, with the home button being the only way to exit. There's no way to go back to browser or youtube app that initiated the video.

This is bad UX and we should fix it in the 1.1 timeframe.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Please renom when this has a priority and an assignee for the UX work for 1.1 so we can track based on criticality of the fix to the release of the product.

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Pull request to show back button when spinner is spinning

Comment 3

[David Flanagan [:djf]]

Comment on attachment 760754 [details] [review]
Pull request to show back button when spinner is spinning

Punam,

I think this bug was actually fixed a long time ago. If you tap the screen while the spinner is spinning, the controls will show, and then you can use the back button in the top-left. I'm not sure when that happened or why this bug didn't get closed at the time.

So I think your patch is unnecessary and we can just close this bug.

Or, you could create a different patch that just made the controls show by default and didn't hide them until after the video started playing.  But then we'd have the issue of a non-fucnctional pause button showing.

This whole way of showing youtube videos is probably going to go away soon, so its not worth spending a lot of time on little details like these. I'd recommend that we just close this and move on.

Comment 4

[Punam Dahiya [:pdahiya]]

As per David comments #c3, this issue is resolved in a related bug. Marking the bug as resolved.