841126 - Patch to overcome the limitation that you can't bind an SCTP port number specific to an DTLS connection

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Michael Tüxen]

Attachment: Patch for Datachannel sources and the corresponding unit tests.

The attached patch allows SCTP sockets to be bound to specific connections when
using AF_CONN. This allows to use the same SCTP port number on both sides of
an association even when used in different tabs of the same browser.
While there, fix the bug the ECN support was announced in the SCTP handshake
even the Firefox infrastructure doesn't support it.

Please note that an update of SCTP sources is required to support the required
functionality.

Please note that the local patches applied in
https://bugzilla.mozilla.org/show_bug.cgi?id=828154
need the following change:
* No change required to usrsctp.h, the patch was incorrect.
* No change required anymore to user_recv_thread.c, since the patch has been
  included upstream.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Update DataChannels to use new stack option to ignore port numbers over DTLS links

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 730566 [details] [diff] [review]
Update DataChannels to use new stack option to ignore port numbers over DTLS links

Un-bitrotted patch; r+

Works when combined with bug 855623 (one-way-open protocol change) and bug 855620 (sctp lib update)

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3bfbdf4db3e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c3bfbdf4db3e