841321 - [COST CONTROL] Wifi statistics are not correctly reseted, you can see old data when you change to another SIM

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Carlos Martínez Toral [:carlosmartinez]]

Tested in unagi with Gecko-8ed37c2.Gaia-21cedfd.

STR:
1-Insert and configure one SIM
2-Surf the internet for a while
3-Verify Wifi data usage is tracked
4-Go to cost control app settings
5-Reset data usage data
6-Verify is set to 0 in both 3G and Wifi
7-Change to another SIM, configured or not
8-Open cost control app

Expected result --> As you have reseted Wifi usage, you should see 0

Actual result --> You see wifi data usage from the other SIM

Comment 1

[Alex Keybl [:akeybl]]

WiFi data is not critical to the CC feature. We would accept a low risk fix if found on the order of days, otherwise this will go unfixed in v1.0.1.

Comment 2

[Salvador de la Puente González [:salva]]

Attachment: Moving wifi fixing as global option since Wi-Fi is not SIM specific

Note this patch indent a block so use ?w=1 to see the real (and few) changes.

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 715112 [details]
Moving wifi fixing as global option since Wi-Fi is not SIM specific

Simple change, tested on the phone.

Thanks Salva!

Comment 4

[Salvador de la Puente González [:salva]]

Master: 6f774ab713a564aa8469d34f2e4aeff7df9da030

Comment 5

[Salvador de la Puente González [:salva]]

Comment on attachment 715112 [details]
Moving wifi fixing as global option since Wi-Fi is not SIM specific

[Approval Request Comment]
Bug caused by (feature/regressing bug #): yes
User impact if declined: high
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch:

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 715112 [details]
Moving wifi fixing as global option since Wi-Fi is not SIM specific

Low risk fix with high user impact for shipping, approving to v1-train uplift.

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 6f774ab713a564aa8469d34f2e4aeff7df9da030 as:
v1-train: 86fe839ec4cc8a9544041aba0d4d17da0ee93546

Comment 8

[Salvador de la Puente González [:salva]]

(In reply to Alex Keybl [:akeybl] from comment #1)
> WiFi data is not critical to the CC feature. We would accept a low risk fix
> if found on the order of days, otherwise this will go unfixed in v1.0.1.

You should note data usage is the only feature provided for non VIVO SIMs so if WiFi counters is not working, we are loosing 50% of its functionality. 

Trying to blocking on this to resolve bug 820414. In addition, you can check comment 6 and comment 3 to see its a very low risk patch with a lot of impact in the user experience.

Thanks for your consideration.

Comment 9

[Daniel Coloma:dcoloma]

Brazil is a country in which SIM swap scenarios is pretty common, so I think we need to fix this one.

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

v1.0.1: 86fe839ec4cc8a9544041aba0d4d17da0ee93546

Comment 11

[Jeni]

Can you please provide steps to verify this fix - as we will blackbox test from the UI?

Comment 12

[mlevin]

Verified fixed the issue of re-opening Usage after inserting a new SIM. Wifi data usage was reset back to zero. In fact User had to set up Usage from scratch which is expected after doing the steps as described in Description above.

Environmental  Variables:
Inari Build ID: 20130430070201
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/010498e599a7
Gaia: de0f1fc6c58616b8a33fca482f1f8684d4e74e9e

Still needs to be verified on b2g18 though.

Comment 13

[mlevin]

Verified fixed the issue of re-opening Usage after inserting a new SIM. Wifi data usage was reset back to zero. In fact User had to set up Usage from scratch which is expected after doing the steps as described in Description above.


Environmental  Variables:
Unagi Build ID: 20130503070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8becaf2a0bc7
Gaia: b0aca0dd1e2955e11190ede725e1fb9ee596438b