Closed Bug 841636 Opened 7 years ago Closed 7 years ago

Temporarily disable WebRTC in SeaMonkey build to work around bug 837618

Categories

(SeaMonkey :: Build Config, defect, blocker)

All
macOS
defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ewong, Assigned: ewong)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #839046 +++

Bug 837618 is a problem where the list of file names for object files to be linked together is too long for the linker to handle. It can be fixed in clang, but in the meantime our Mac nightlies are broken.

I'm proposing that we temporarily disable WebRTC (which has plenty of object files should give us some breathing space), and in actual fact is not correctly packaged at the moment anyway, also on top of that argument, is that WebRTC hasn't yet been fully enabled in trunk.

Once bug 837618 is fixed, then we can re-enable WebRTC properly with the appropriate packaging etc.
Severity: normal → blocker
Attachment #714215 - Flags: review?(bugspam.Callek)
Comment on attachment 714215 [details] [diff] [review]
Temporarily disable WebRTC. (v1)

Review of attachment 714215 [details] [diff] [review]:
-----------------------------------------------------------------

Patch is technically sound, but on the matter of "Do we want it" I'm unsure when I can get around to looking deep enough to make the call. I know me and Ratty were discussing this recently. So if he feels we should, happy to have him mark this r+ for me.
Attachment #714215 - Flags: review?(philip.chee)
Comment on attachment 714215 [details] [diff] [review]
Temporarily disable WebRTC. (v1)

f=me but Callek will make the final decision.
Attachment #714215 - Flags: review?(philip.chee) → feedback+
Comment on attachment 714215 [details] [diff] [review]
Temporarily disable WebRTC. (v1)

After discussion on IRC, I'm changing my f+ to r+ to get our OSX buildbots building again.
Attachment #714215 - Flags: review+
symbols.def : error LNK2001: unresolved external symbol vpx_codec_vp8_cx
gkmedias.lib : fatal error LNK1120: 1 unresolved externals

Something seems to have regressed Bug 799069 - Unresolved vpx_codec_vp8_cx export in --disable-webrtc build

Or perhaps I just need a clobber?
Comment on attachment 714215 [details] [diff] [review]
Temporarily disable WebRTC. (v1)

Review of attachment 714215 [details] [diff] [review]:
-----------------------------------------------------------------

Ratty took care of this review :-)
Attachment #714215 - Flags: review?(bugspam.Callek)
AIUI, this was backed out a while, so I'm closing this.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.