841642 - Re-enable WebRTC after bug 837618 is fixed.

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Bug 837618 has been fixed, we can re-enable webrtc (mostly to fix broken tests for now).

Comment 2

[Edmund Wong (:ewong)]

Comment on attachment 741345 [details] [diff] [review]
Patch

Technically speaking, I'm not a build config peer and thusly I can't review this.
I can, however, give a feedback. :)  (Sorry Mcsmurf..  )

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 741345 [details] [diff] [review]
Patch

Review of attachment 741345 [details] [diff] [review]:
-----------------------------------------------------------------

We *probably* need packager changes ala https://bugzilla.mozilla.org/show_bug.cgi?id=839272 -- but for the short-term lets get this in, which may likely help anyway.

Comment 4

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/comm-central/rev/9e52d464e235

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Since bug 837618 is marked fixed for mozilla23, shouldn't we also push this to Aurora? Just noting here before I forget, because there's now a "WebRTC is now enabled by default" item on the SM 2.19 relnotes that I probably need to revise.

Comment 6

[Frank Wein [:mcsmurf]]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #5)
> Since bug 837618 is marked fixed for mozilla23, shouldn't we also push this
> to Aurora? Just noting here before I forget, because there's now a "WebRTC
> is now enabled by default" item on the SM 2.19 relnotes that I probably need
> to revise.

Sorry Jens, totally missed the bugmail from your comment :(. You're right, WebRTC is not available yet in SeaMonkey. WebRTC core code was/is mainly included to reduce the number of mochitest failures. To get WebRTC itself working in the browser, we need to implement the doorhanger UI so that the user can grant/deny access for mic/cam/etc. (probably the next project I'll work on).