Closed Bug 841642 Opened 7 years ago Closed 6 years ago

Re-enable WebRTC after bug 837618 is fixed.

Categories

(SeaMonkey :: Build Config, defect)

x86
Windows Vista
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.21

People

(Reporter: ewong, Assigned: mcsmurf)

References

Details

Attachments

(1 file)

No description provided.
Depends on: 837618
Summary: Re-enable WebRTC after bug bug 837618 is fixed. → Re-enable WebRTC after bug 837618 is fixed.
Attached patch PatchSplinter Review
Bug 837618 has been fixed, we can re-enable webrtc (mostly to fix broken tests for now).
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #741345 - Flags: review?(ewong)
Attachment #741345 - Flags: review?(ewong) → review+
Comment on attachment 741345 [details] [diff] [review]
Patch

Technically speaking, I'm not a build config peer and thusly I can't review this.
I can, however, give a feedback. :)  (Sorry Mcsmurf..  )
Attachment #741345 - Flags: review?(bugspam.Callek)
Attachment #741345 - Flags: review+
Attachment #741345 - Flags: feedback+
Comment on attachment 741345 [details] [diff] [review]
Patch

Review of attachment 741345 [details] [diff] [review]:
-----------------------------------------------------------------

We *probably* need packager changes ala https://bugzilla.mozilla.org/show_bug.cgi?id=839272 -- but for the short-term lets get this in, which may likely help anyway.
Attachment #741345 - Flags: review?(bugspam.Callek) → review+
Pushed: https://hg.mozilla.org/comm-central/rev/9e52d464e235
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.21
Since bug 837618 is marked fixed for mozilla23, shouldn't we also push this to Aurora? Just noting here before I forget, because there's now a "WebRTC is now enabled by default" item on the SM 2.19 relnotes that I probably need to revise.
(In reply to Jens Hatlak (:InvisibleSmiley) from comment #5)
> Since bug 837618 is marked fixed for mozilla23, shouldn't we also push this
> to Aurora? Just noting here before I forget, because there's now a "WebRTC
> is now enabled by default" item on the SM 2.19 relnotes that I probably need
> to revise.

Sorry Jens, totally missed the bugmail from your comment :(. You're right, WebRTC is not available yet in SeaMonkey. WebRTC core code was/is mainly included to reduce the number of mochitest failures. To get WebRTC itself working in the browser, we need to implement the doorhanger UI so that the user can grant/deny access for mic/cam/etc. (probably the next project I'll work on).
You need to log in before you can comment on or make changes to this bug.