Work - Open in tab doesn't work for image context menu

VERIFIED FIXED

Status

Firefox for Metro
General
VERIFIED FIXED
6 years ago
4 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
x86_64
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: feature=work status=verified)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
eom
(Assignee)

Comment 1

6 years ago
Created attachment 714308 [details] [diff] [review]
patch
Attachment #714308 - Flags: review?(mbrubeck)
Comment on attachment 714308 [details] [diff] [review]
patch

Review of attachment 714308 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/ContextCommands.js
@@ +138,5 @@
>    },
>  
> +  openImageInNewTab: function cc_openImageInNewTab() {
> +    Browser.addTab(ContextMenuUI.popupState.mediaURL, false, Browser.selectedTab);
> +    ContextUI.peekTabs();

You can use BrowserUI.newTab() here.  (The rough sort-of-rule is that BrowserUI methods can be used when responding to explicit user actions, and they will do the appropriate UI stuff like peekTabs.)
Attachment #714308 - Flags: review?(mbrubeck) → review+
(In reply to Matt Brubeck (:mbrubeck) from comment #2)
> You can use BrowserUI.newTab() here.

For bonus points you can fix openInNewTab to do the same.  :)
(Assignee)

Comment 4

6 years ago
fixed by the landing in bug 841686.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Tested on 2013-02-21 Nightly built from http://hg.mozilla.org/mozilla-central/rev/702d2814efbf
- All items in the image context menu work now.
Summary: Open in tab doesn't work for image context menu → Work - Open in tab doesn't work for image context menu
Whiteboard: feature=work status=verified

Updated

6 years ago
Status: RESOLVED → VERIFIED
Depends on: 846621
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.