841688 - Work - Open in tab doesn't work for image context menu

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Jim Mathies [:jimm]]

eom

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 714308 [details] [diff] [review]
patch

Review of attachment 714308 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/ContextCommands.js
@@ +138,5 @@
>    },
>  
> +  openImageInNewTab: function cc_openImageInNewTab() {
> +    Browser.addTab(ContextMenuUI.popupState.mediaURL, false, Browser.selectedTab);
> +    ContextUI.peekTabs();

You can use BrowserUI.newTab() here.  (The rough sort-of-rule is that BrowserUI methods can be used when responding to explicit user actions, and they will do the appropriate UI stuff like peekTabs.)

Comment 3

[Matt Brubeck (:mbrubeck)]

(In reply to Matt Brubeck (:mbrubeck) from comment #2)
> You can use BrowserUI.newTab() here.

For bonus points you can fix openInNewTab to do the same.  :)

Comment 4

[Jim Mathies [:jimm]]

fixed by the landing in bug 841686.

Comment 5

[juan becerra [:juanb]]

Tested on 2013-02-21 Nightly built from http://hg.mozilla.org/mozilla-central/rev/702d2814efbf
- All items in the image context menu work now.