833165 - Story - Context menu for images

Status: VERIFIED FIXED

(Tracking Graveyard :: Metro Operations, defect, P2)

Description

[Asa Dotzler [:asa]]

Attachment: UC-151 Context menu for images

Comment 1

[Asa Dotzler [:asa]]

Attachment: UC-9-31 Context menu for images

Comment 2

[Jim Mathies [:jimm]]

I'd like to discuss the image options at some point. For example "Save Image To" is pretty useful in some cases. Bug 837932 is all about getting libraries hooked up right.

Comment 3

[Asa Dotzler [:asa]]

(In reply to Jim Mathies [:jimm] from comment #2)
> I'd like to discuss the image options at some point. For example "Save Image
> To" is pretty useful in some cases. Bug 837932 is all about getting
> libraries hooked up right.

Good idea. Thanks, Jim. I'll talk with UX about this and if appropriate get a v2 story filed.

Comment 4

[Jim Mathies [:jimm]]

Attachment: image context menu

Comment 5

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #4)
> Created attachment 710358 [details]
> image context menu

In this - 

Save Image - goes to the library after bug 837932 is fixed.
Save Image To - brings up the picker and honors our old last downloads dir pref.
Copy Image Location - copy the uri of the image to clipboard (not the image)
View in New Tab - obvious

Comment 6

[Asa Dotzler [:asa]]

The story called for this:

    View image
    Copy image
    Save to picture library

The m-c nightly from 2013-02-14 contains this:

    View in new tab (which failed, opening a blank tab instead)
    Copy image
    Save image
    Save image to

We're changing the story to ask for this: 

    Save to Picture Library
    Copy Image
    Copy Image location
    Open Image in New Tab

So, what we need are for the items to be re-arranged to put Save to Picture Library first, followed by Copy Image, Copy Image Location, and Open Image in New Tab. We need to get rid of Save image to. Also, we need Open Image in New Tab to actually open the image.

If the implementation had matched the spec, I think the right process would be to leave this bug closed and create a new "Change" bug to cover the differences between the implementation and the spec and a "Defect" for the broken "Open Image in New Tab". Because we're not done with the cycle yet, I'm just re-opening this with the slight adjustment to the story, plus the defect.

Comment 7

[juan becerra [:juanb]]

Tested on 2013-02-21 Nightly built from http://hg.mozilla.org/mozilla-central/rev/702d2814efbf
- The options and their order now match the story.

Comment 8

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Story" for iteration #5 testing and found a defect/change. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-14-03-10-25-mozilla-central/

Went through the following test cases:

- Ensured everything matched what was described in Comment 6
- Ensured that "Save to picture library" correctly saves the image and into the correct location
- Ensured that "Copy image location" worked without any issues (Link being copied into the clipboard)
- Copied several images (Small, Medium, Large, Huge) into the clipboard and pasted it into "mspaint" and ensured it was the correct image and size
- Copied several images in a row and ensured that last one was correctly pasted into "mspaint" from the clipboard
- Copied several different image formats (JPG, PNG, GIF, BMP)
- Ensured that "Open link in new tab" worked without any issues

Issues Found:

- Images are not being placed into the clipboard if "Copy Image" is tapped before the website completely loads
- When tapping on an image that is a link, you will receive both "Copy image location" and "Copy link"
Went through the following "Story" for iteration #5 testing and found a defect/change. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-14-03-10-25-mozilla-central/

Went through the following test cases:

- Ensured everything matched what is described in Comment 6
- Ensured that "Save to picture library" correctly saves the image and into the correct location
- Ensured that "Copy image location" worked without any issues (Link being copied into the clipboard)
- Copied several images (Small, Medium, Large, Huge) into the clipboard and pasted it into "mspaint" and ensured it was the correct image and size
- Copied several images in a row and ensured that last one was correctly pasted into "mspaint" from the clipboard
- Copied several different image formats (JPG, PNG, GIF, BMP)
- Ensured that "Open link in new tab" worked without any issues

Issues Found:

- Images are not being placed into the clipboard if "Copy Image" is tapped before the website completely loads
- When tapping on an image that is a link, you will receive both "Copy image location" and "Copy link"

Attached both the Defect and Change into this ticket

Comment 9

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130808030205
Built from http://hg.mozilla.org/mozilla-central/rev/fd4cf30428b0

WFM
Tested on windows 8 using latest nightly  for iteration-11. Followed steps provided in user story and got expected result.

Comment 10

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in user story and got expected result.

Comment 11

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Story" for iteration #15 (touch device verification) with some issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-10-15-03-03-19-mozilla-central/

- Went through the original "Story" in comment #0 without any issues
- Ensured that all the test cases matched what was described in comment #6
- Ensured that when saving image(s) to "Picture Library", both "Run" & "Show in Files" worked without any problems
- Ensured that all of the above test cases worked in full & filled views

Found an issue and created bug 927239 when going through the following "Story"