841693 - Contacts settings customization

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Joe Cheng [:jcheng] (please needinfo)]

This is customization setting request for Contacts app
- Default name format of contacts in device
- Default sort order of contacts in device phone book

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

currently we only have "Order by last name" ON/OFF in contacts settings

Comment 2

[Kai-Chih Hu [:khu]]

Now, the default value for the ON/OFF can't be changed. It's hard coded now.

Comment 3

[Jose Manuel Cantera]

Hi,

Ordering settings have been fixed by bug 841082 which landed on master and we requested an approval for v1-train.

thanks, best

Comment 4

[alberto.pastor]

I think what they mean is being able to configure the default value (?)

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

(In reply to Alberto Pastor from comment #4)
> I think what they mean is being able to configure the default value (?)

Correct

Comment 6

[Jose Manuel Cantera]

can we set it to config.json ? 

should be pretty easy to be fixed

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

(In reply to Jose M. Cantera from comment #6)
> can we set it to config.json ? 
> 
> should be pretty easy to be fixed

will you be able to provide a patch? thanks

also, i hope to confirm that without customization on this item "Order by last name", the default value is OFF, which means the sort order is "First Name, Last Name"? Thanks

Comment 8

[Jose Manuel Cantera]

(In reply to Joe Cheng [:jcheng] from comment #7)
> (In reply to Jose M. Cantera from comment #6)
> > can we set it to config.json ? 
> > 
> > should be pretty easy to be fixed
> 
> will you be able to provide a patch? thanks
> 

of course, myself or Cristian can do that 

> also, i hope to confirm that without customization on this item "Order by
> last name", the default value is OFF, which means the sort order is "First
> Name, Last Name"? Thanks

I think, Beatriz or David, can confirm that

Comment 9

[Kai-Chih Hu [:khu]]

It blocks shira delivery. Shira+.

Comment 10

[David Palomino [:dpalomino]]

> > also, i hope to confirm that without customization on this item "Order by
> > last name", the default value is OFF, which means the sort order is "First
> > Name, Last Name"? Thanks
> 
> I think, Beatriz or David, can confirm that

From my understanding, it's better to order by: 

1st: First Name
2nd: Last Name

Thks!
David

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

(In reply to Jose M. Cantera from comment #8)
> (In reply to Joe Cheng [:jcheng] from comment #7)
> > will you be able to provide a patch? thanks
> of course, myself or Cristian can do that 

Jose, since you can provide a patch on this. changing assignee to you. Thanks

Comment 12

[Lucas Adamski [:ladamski]]

Why is this shira+?  Its not a DT request.  Some rationale for why this should block at all would be nice.

Comment 13

[Jose Manuel Cantera]

Attachment: Pointer to GH PR

The patch allows to set the default contacts ordering in the config.json file of the Contacts App. 

It is out of scope of this patch the automatic generation of the config.json file through the Gaia makefile or similar.

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

(In reply to Lucas Adamski from comment #12)
> Why is this shira+?  Its not a DT request.  Some rationale for why this
> should block at all would be nice.

back to Shira+ as the justification was provided over an email to Lucas regarding partner specific request for this to be done

Comment 15

[Jose Manuel Cantera]

An additional field has been added to the config.json file.

The field name is 'defaultContactsOrder' and the possible values are 'familyName' or 'givenName'. 'familyName' indicates that contacts should be ordered initially by surname and 'givenName' indicates that contacts should be ordered initially by first name.

Comment 16

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/cc7e221dc8ce80ab8eb49481ef7f3955f4ad3b04

Comment 17

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train@a1b2b8280a70c172f491dc071d372d80875fd098
v1.0.1@0c80ae9ae2b7c11dd0aa39a2f649a9513f7ab204

Comment 18

[sarsenyev]

Environmental  Variables:
Unagi Build ID: 20130329070203
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v
Gaia: 0a9f78bffafda93a159c1f502e8b110c2f49a500

Verified the bug has been fixed
Setting customization has been improved
Ordering settings have been fixed
"Order by Last Name" is OFF by default and the Contacts sorted by Given name.
Able to toggle "Order by Last Name" between ON/OFF, when "Order by Last Name" is ON, the contacts ordered by Last name correctly in order.