Flip the pref to enable <input type=range> on Nightly and Aurora

VERIFIED FIXED in mozilla22

Status

()

Core
DOM: Core & HTML
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

({dev-doc-needed})

Trunk
mozilla22
dev-doc-needed
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(relnote-firefox -)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

4 years ago
Blocks: 841950
I think we should enable <input type'range'> on Nightly and Aurora as soon as we have an element that has a working DOM and a working layout. No need for a bug-free implementation a native styling.

I think if we open a bug to implement the thumb moving in layout, this bug would depend on all bugs needed to fix it.
Blocks: 344618
Depends on: 836314, 838256
No longer depends on: 344618
Jonathan, as far as I understand it, the only thing missing to be able to land this the able to move the thumb. Ideally, with the keyboard and the mouse.
(Assignee)

Updated

4 years ago
Depends on: 843725
(Assignee)

Updated

4 years ago
Depends on: 846380
(Assignee)

Comment 3

4 years ago
Created attachment 721912 [details] [diff] [review]
patch
Attachment #721912 - Flags: review?(mounir)
Comment on attachment 721912 [details] [diff] [review]
patch

Review of attachment 721912 [details] [diff] [review]:
-----------------------------------------------------------------

w00t! :)
Attachment #721912 - Flags: review?(mounir) → review+
Jonathan, is there a specific reason why you didn't land that patch?
(Assignee)

Comment 6

4 years ago
Yes, I specifically want to fix bug 842179 before asking people whether the pseudo-elements meet their needs.
Depends on: 842179
(Assignee)

Comment 7

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc80b4d5c4ec

Assuming this sticks and there are no major issues, I'll blog about it to ask for people to test after it reaches latest Nightlies.
https://hg.mozilla.org/mozilla-central/rev/fc80b4d5c4ec
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Keywords: dev-doc-needed
relnote-firefox: --- → ?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:22.0) Gecko/20130403 Firefox/22.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130403 Firefox/22.0
Mozilla/5.0 (X11; Linux i686; rv:22.0) Gecko/20130402 Firefox/22.0
BuildID: 20130402004013

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:23.0) Gecko/20130404 Firefox/23.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130403 Firefox/23.0
Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20130403 Firefox/23.0
BuildID: 20130403090950

I verified that the dom.experimental_forms_range pref is "true" in about:config and that the type="range" attribute works without triggering any errors in pages.
Hence marking bug as Verified.
Status: RESOLVED → VERIFIED

Updated

4 years ago
relnote-firefox: ? → 22+
This bug has been listed as part of the Aurora 22 release notes in either [1], [2], or both. If you find any of the information or wording incorrect in the notes, please email release-mgmt@mozilla.com asap. Thanks!

[1] https://www.mozilla.org/en-US/firefox/22.0a2/auroranotes/
[2] https://www.mozilla.org/en-US/mobile/22.0a2/auroranotes/
(Assignee)

Comment 11

4 years ago
Sent this to release-mgmt@:

This bug will most likely not stay enabled for v22. Either the release notes should mention that, or the release notes probably shouldn't mention the feature at all.
(In reply to Jonathan Watt [:jwatt] from comment #11)
> Sent this to release-mgmt@:
> 
> This bug will most likely not stay enabled for v22. Either the release notes
> should mention that, or the release notes probably shouldn't mention the
> feature at all.

Thanks Jonathan - we'll wait to communicate this until it's going to be enabled by default for release users. Thanks!
relnote-firefox: 22+ → -
You need to log in before you can comment on or make changes to this bug.