841969 - Make mozdevice's ADB manager less chatty

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Every time we initialise DeviceManagerADB we get the version printed to stdout. Also, when copying files we often see "'cp' not found, but 'dd' was found as a replacement". This makes following results in the console difficult.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Make mozdevice less chatty. v1.0

Too extreme?

Comment 2

[William Lachance (:wlach)]

(In reply to Dave Hunt (:davehunt) from comment #0)
> Also, when copying files we often see "'cp' not found, but 'dd' was
> found as a replacement". This makes following results in the console
> difficult.

I wonder why we don't always just use 'dd', since it's always there. That would eliminate the need for these sorts of checks altogether. :gbrown?

Comment 3

[Geoff Brown [:gbrown]]

I think we used cp initially, then added dd as a fallback when we discovered devices without cp. I suspect using dd all the time would work just fine.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Make mozdevice less chatty. v1.1

Also silence stderr.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Geoff Brown [:gbrown] from comment #3)
> I think we used cp initially, then added dd as a fallback when we discovered
> devices without cp. I suspect using dd all the time would work just fine.

Could we take care of this in a separate bug? I wouldn't want to introduce a regression when all I'm wanting to do is reduce console output.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 715180 [details] [diff] [review]
Make mozdevice less chatty. v1.1

Review of attachment 715180 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good.  I would rather fix the dd by default in another bug, it seems as though most people who are trying to run tests have problems and devicemanagerADB causes a lot of frustration.

Comment 7

[Andrew Halberstadt [:ahal]]

I think this bug is kind of a duplicate of bug 793202. In that scheme we'd log all these messages at the DEBUG level, but run it at the INFO level by default. That way we won't lose potential debugging info.

If you don't want to wait for bug 793202 feel free to land and I'll make a note there to re-enable this message at the DEBUG level.

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed as:
https://github.com/mozilla/mozbase/commit/0ff6514efff72a929fb33de16834bd73fce1283e

Ahal: Sounds good to change this to a debug log. Let me know if you need anything from me.

Comment 9

[William Lachance (:wlach)]

(In reply to Dave Hunt (:davehunt) from comment #5)
> (In reply to Geoff Brown [:gbrown] from comment #3)
> > I think we used cp initially, then added dd as a fallback when we discovered
> > devices without cp. I suspect using dd all the time would work just fine.
> 
> Could we take care of this in a separate bug? I wouldn't want to introduce a
> regression when all I'm wanting to do is reduce console output.

I filed bug 842668 to take care of this.