842668 - Should always use dd instead of cp in devicemanagerADB

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[William Lachance (:wlach)]

It was brought up in bug 841969 (https://bugzilla.mozilla.org/show_bug.cgi?id=841969#c3) that supporting both "dd" and "cp" for copying around files on Android is a bit silly -- dd does everything we need and is available on all platforms. We should just use that instead all the time.

Comment 1

[William Lachance (:wlach)]

Attachment: Always use dd instead of cp

On investigation, it looks like all this "dd" stuff has to do with our run-as support in dmADB, which I was never sure was a good idea. But we can cross that bridge later, for now this seems like a nice simplification to me.

Comment 2

[William Lachance (:wlach)]

Some code in m-c relies on the _useDDCopy variable. We should fix that in this bug too:

http://mxr.mozilla.org/mozilla-central/search?string=useDDCopy

(we don't need for the mozdevice changes to land before doing that -- since all b2g devices have dd available)

Comment 3

[William Lachance (:wlach)]

Attachment: Patch to always use dd copy from b2g unit/ref tests

Comment 4

[William Lachance (:wlach)]

(In reply to William Lachance (:wlach) from comment #3)
> Created attachment 716072 [details] [diff] [review]
> Patch to always use dd copy from b2g unit/ref tests

Did a try run to go along with this one: https://tbpl.mozilla.org/?tree=Try&rev=dcb49022a43f

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 716072 [details] [diff] [review]
Patch to always use dd copy from b2g unit/ref tests

Review of attachment 716072 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!

Comment 6

[William Lachance (:wlach)]

Inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/67f2a2816651

Comment 7

[William Lachance (:wlach)]

Mozbase Push: https://github.com/mozilla/mozbase/commit/66bd6b7207bc3a359e831f9671983ba33b99d25c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/67f2a2816651