841983 - require whitespace around 'and', 'or', and after 'not' in @supports rules

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Require whitespace around 'not', 'and', and 'or' keywords in @supports rules.

Matches spec change in https://dvcs.w3.org/hg/csswg/rev/34b185ae3bac .

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 714709 [details] [diff] [review]
Require whitespace around 'not', 'and', and 'or' keywords in @supports rules.

Review of attachment 714709 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that.

::: dom/locales/en-US/chrome/layout/css.properties
@@ +120,5 @@
>  PEBadDirValue=Expected 'ltr' or 'rtl' in direction selector but found '%1$S'.
>  PESupportsConditionStartEOF2='not', '(', or function
>  PESupportsConditionInParensEOF=')'
>  PESupportsConditionNotEOF='not'
> +PESupportsWhitespaceRequired=Expected whitespace after 'not', 'and', or 'or'.

This should be "Expected whitespace after 'not', or before and after 'and' or 'or'.", but that might be getting a bit confusing.  Can you find some wording that captures the "white space after 'and' and 'or'" requirement too, or maybe split this into two separate error messages (one for "not" and another for "and" and "or")?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Except the way the code is structured, it'll never give that error before an 'and' or an 'or'; it'll just finish parsing the conjunction or disjunction and report the next thing as unexpected.

Comment 4

[Cameron McCormack (:heycam)]

OK, fair enough.  One other thing I was going to mention that I forgot to: can you update the comments above each of the Parse*() functions that have the grammar snippets in them to match what you are now parsing?

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20abb67042df

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/20abb67042df