Closed Bug 842008 Opened 11 years ago Closed 11 years ago

unable to delete saved search

Categories

(Thunderbird :: Folder and Message Lists, defect)

21 Branch
defect
Not set
normal

Tracking

(thunderbird20 fixed, thunderbird21 fixed)

VERIFIED FIXED
Thunderbird 22.0
Tracking Status
thunderbird20 --- fixed
thunderbird21 --- fixed

People

(Reporter: post, Assigned: aryx)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20100101 Firefox/18.0
Build ID: 20130201065344

Steps to reproduce:

created a saved search. was saved as virtual folder. later attempted to delete it. 


Actual results:

delete request is ignored, i.e. nothing happens


Expected results:

saved search should be deleted. messages found in search should be unaffected
Anything in Tools->Error console AFTER the failed attempt to delete the folder?

But I can confirm this problem. I wonder if this worked in the past.
Status: UNCONFIRMED → NEW
Ever confirmed: true
(In reply to :aceman from comment #1)
> Anything in Tools->Error console AFTER the failed attempt to delete the
> folder?
> 
> But I can confirm this problem. I wonder if this worked in the past.

nothing in error console
Ok, I see the problem, there is a typo from a recent change.

Tue Feb 19 2013 21:27:17
Error: ReferenceError: Servics is not defined
Source file: chrome://messenger/content/folderPane.js
Line: 2146

if (Servics.prompts
           .confirmEx(window, title, confirmation,

I assume Aryx will clean it up :)
Assignee: nobody → archaeopteryx
Status: NEW → ASSIGNED
OS: Windows 7 → All
Hardware: x86_64 → All
There was a second typo in that line (or the cursor had been shifted one byte to the left), also fixing that.
Attachment #715678 - Attachment is obsolete: true
Attachment #715678 - Flags: review?(kent)
Attachment #715705 - Flags: review?(kent)
Attachment #715705 - Flags: review?(mkmelin+mozilla)
Comment on attachment 715705 [details] [diff] [review]
patch fixing two typo, v2

Review of attachment 715705 [details] [diff] [review]:
-----------------------------------------------------------------

nice catch, r=mkmelin!
Attachment #715705 - Flags: review?(mkmelin+mozilla) → review+
Blocks: 795152
Keywords: regression
Attachment #715705 - Flags: review?(kent)
Keywords: checkin-needed
(In reply to Archaeopteryx [:aryx] from comment #5)
> Created attachment 715705 [details] [diff] [review]
> patch fixing two typo, v2
> 
A typo in the description of a patch fixing a typo :) Nice one, Aryx ! :)

[missing 's']
https://hg.mozilla.org/comm-central/rev/f10a1c2973fd
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 22.0
retested on daily 22-02-2013. fixed. nice one! thanks Aryx
Status: RESOLVED → VERIFIED
Comment on attachment 715705 [details] [diff] [review]
patch fixing two typo, v2

The original breaking patch went into TB20 so we may want to fix it there too.

[Approval Request Comment]
Regression caused by (bug #): bug 842008
User impact if declined: inability to delete virtual folder
Testing completed (on c-c, etc.): TB22
Risk to taking this patch (and alternatives if risky): none
Attachment #715705 - Flags: approval-comm-beta?
Attachment #715705 - Flags: approval-comm-aurora?
Comment on attachment 715705 [details] [diff] [review]
patch fixing two typo, v2

a=me
Attachment #715705 - Flags: approval-comm-beta?
Attachment #715705 - Flags: approval-comm-beta+
Attachment #715705 - Flags: approval-comm-aurora?
Attachment #715705 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.