842008 - unable to delete saved search

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[helkav]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20100101 Firefox/18.0
Build ID: 20130201065344

Steps to reproduce:

created a saved search. was saved as virtual folder. later attempted to delete it. 


Actual results:

delete request is ignored, i.e. nothing happens


Expected results:

saved search should be deleted. messages found in search should be unaffected

Comment 1

[:aceman]

Anything in Tools->Error console AFTER the failed attempt to delete the folder?

But I can confirm this problem. I wonder if this worked in the past.

Comment 2

[helkav]

(In reply to :aceman from comment #1)
> Anything in Tools->Error console AFTER the failed attempt to delete the
> folder?
> 
> But I can confirm this problem. I wonder if this worked in the past.

nothing in error console

Comment 3

[:aceman]

Ok, I see the problem, there is a typo from a recent change.

Tue Feb 19 2013 21:27:17
Error: ReferenceError: Servics is not defined
Source file: chrome://messenger/content/folderPane.js
Line: 2146

if (Servics.prompts
           .confirmEx(window, title, confirmation,

I assume Aryx will clean it up :)

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch fixing typo, v1

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch fixing two typo, v2

There was a second typo in that line (or the cursor had been shifted one byte to the left), also fixing that.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 715705 [details] [diff] [review]
patch fixing two typo, v2

Review of attachment 715705 [details] [diff] [review]:
-----------------------------------------------------------------

nice catch, r=mkmelin!

Comment 7

[:aceman]

(In reply to Archaeopteryx [:aryx] from comment #5)
> Created attachment 715705 [details] [diff] [review]
> patch fixing two typo, v2
> 
A typo in the description of a patch fixing a typo :) Nice one, Aryx ! :)

[missing 's']

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/f10a1c2973fd

Comment 9

[helkav]

retested on daily 22-02-2013. fixed. nice one! thanks Aryx

Comment 10

[:aceman]

Comment on attachment 715705 [details] [diff] [review]
patch fixing two typo, v2

The original breaking patch went into TB20 so we may want to fix it there too.

[Approval Request Comment]
Regression caused by (bug #): bug 842008
User impact if declined: inability to delete virtual folder
Testing completed (on c-c, etc.): TB22
Risk to taking this patch (and alternatives if risky): none

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 715705 [details] [diff] [review]
patch fixing two typo, v2

a=me

Comment 12

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/42e9558e7cc3

Comment 13

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-beta/rev/fa8307cf2bda