842106 - Permanent red: /installer/package-name.mk:143: /builds/slave/tb-c-cen-lx-000000000000000000/build/config/makefiles/makeutils.mk: No such file or directory

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

comm-central is fully busted. jcranmer suspects bug 746277.

Here's the log spew:

checking for strip... (cached) /usr/bin/strip
checking for windres... no
checking for gcc -pipe support... yes
checking for perl5... (cached) /usr/bin/perl
checking for dlopen... no
checking for dlopen in -ldl... (cached) yes
checking whether /tools/gcc-4.5-0moz3/bin/gcc needs -traditional... (cached) no
checking for lchown... (cached) yes
checking for strerror... (cached) yes
checking for getaddrinfo... yes
checking for getnameinfo... yes
checking for pthread_create in -lpthreads... no
checking for pthread_create in -lpthread... yes
checking for --with-sasl... no
checking for --with-sasl-inc... no
checking for --with-sasl-lib... no
checking for getaddrinfo... (cached) yes
checking for sasl_client_init in -lsasl2... no
checking for sasl_client_init in -lsasl... no
checking whether /tools/gcc-4.5-0moz3/bin/gcc accepts -pthread... yes
updating cache ../../.././config.cache
creating ./config.status
creating Makefile
creating config/Makefile
creating config/autoconf.mk
creating ldap/Makefile
creating ldap/clients/tools/Makefile
creating ldap/include/Makefile
creating ldap/libraries/Makefile
creating ldap/libraries/libldap/Makefile
creating ldap/libraries/libprldap/Makefile
creating ldap/libraries/libldif/Makefile
creating ldap/libraries/liblber/Makefile
creating ldap/libraries/libiutil/Makefile
creating ldap/libraries/libssldap/Makefile
creating ldap/libraries/libutil/Makefile
make[2]: Leaving directory `/builds/slave/tb-c-cen-lx-000000000000000000/build'
make -j6 -C objdir-tb
/builds/slave/tb-c-cen-lx-000000000000000000/build/mozilla/toolkit/mozapps/installer/package-name.mk:143: /builds/slave/tb-c-cen-lx-000000000000000000/build/config/makefiles/makeutils.mk: No such file or directory
make[2]: Entering directory `/builds/slave/tb-c-cen-lx-000000000000000000/build/objdir-tb'
make[2]: *** No rule to make target `/builds/slave/tb-c-cen-lx-000000000000000000/build/config/makefiles/makeutils.mk'.  Stop.
make[2]: Leaving directory `/builds/slave/tb-c-cen-lx-000000000000000000/build/objdir-tb'
make[1]: *** [build] Error 2
make[1]: Leaving directory `/builds/slave/tb-c-cen-lx-000000000000000000/build'
make: *** [build] Error 2
DEBUG: shell: unmounting all filesystems
DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-i386/root/dev/shm
DEBUG: Child return code was: 0
DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-i386/root/dev/pts
DEBUG: Child return code was: 0
DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-i386/root/tmp/ccache
DEBUG: Child return code was: 0
DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-i386/root/targetdata/
DEBUG: Child return code was: 0
DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-i386/root/tmp/.X11-unix
DEBUG: Child return code was: 0
DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-i386/root/builds/git-shared
DEBUG: Child return code was: 0
DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-i386/root/builds/hg-shared
DEBUG: Child return code was: 0
DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-i386/root/builds/ccache
DEBUG: Child return code was: 0
DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-i386/root/builds/slave
DEBUG: Child return code was: 0
DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-i386/root/var/cache/yum
DEBUG: Child return code was: 0
DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-i386/root/sys
DEBUG: Child return code was: 0
DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-i386/root/proc
DEBUG: Child return code was: 0
DEBUG: shell: calling postshell hooks
State Changed: unlock buildroot
program finished with exit code 2
elapsedTime=194.229777
========= Finished compile failed (results: 2, elapsed: 3 mins, 14 secs) (at 2013-02-16 16:30:42.617298) =========

Comment 1

[Mark Banner (:standard8)]

Attachment: Possible fix

I'm still compiling this, but I'm pretty sure it should work.

I'm not thrilled about the patch as it is just copying the files from mozilla-central.

However, I did try going down the route of changing topsrcdir -> MOZILLA_DIR and just got into a maze of the variable not being defined (due to inclusions before rules.mk), and other issues. As I'm now also starting to push on the directory swap around, I think it is probably just easiest if we copy the files for now, rather than mess around m-c loads.

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 714904 [details] [diff] [review]
Possible fix

Not a fan either (especially since m-c files will be calling c-c copies), but this *should* clear us, at least for now.

Comment 3

[Mark Banner (:standard8)]

https://hg.mozilla.org/comm-central/rev/bce8262aabcc

Comment 4

[Frank Wein [:mcsmurf]]

Looks like we might need to insert "AC_SUBST(MOZ_APP_VENDOR)" in comm-central configure.in (at least I think this might fix the next build problem, but I did not test).

Comment 5

[Frank Wein [:mcsmurf]]

Also see Bug 839298 Comment 17 on this for a solution. But I think the real/correct(?) solution would be to make sure all the vars listed in http://hg.mozilla.org/mozilla-central/file/524e7bc67431/toolkit/mozapps/installer/informulate.py are included (probably not the right term) in the buildconfig python module. Not sure how exactly this works though...

Comment 6

[Mark Banner (:standard8)]

I'll take a look, but really the follow-up is a separate issue ;-)

Comment 7

[Frank Wein [:mcsmurf]]

Right, one bug per issue :) I filed Bug 842254 on this.