842228 - Bug 540537 regressed in bug 491947

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Hector Zhao [:hectorz]]

In bug 540537, when setting Firefox as default browser, Software\Classes\https?\shell is set to "open" in AddDDEHandlerValues to fix some aggressive registry modifications made by IE clones in China.

Bug 491947 introduced AddDisableDDEHandlerValues which is based on an early version of AddDDEHandlerValues, and bug 540537 is effectively reverted.

Comment 1

[Hector Zhao [:hectorz]]

Attachment: Patch

This is a basic patch equivalent to that in bug 540537, but maybe some documentation in code comments should be updated to reflect this change?

Comment 2

[Brian R. Bondy [:bbondy]]

Comment on attachment 715042 [details] [diff] [review]
Patch

Review of attachment 715042 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for the patch!

Comment 3

[Hector Zhao [:hectorz]]

Comment on attachment 715042 [details] [diff] [review]
Patch

(In reply to Brian R. Bondy [:bbondy] from comment #2)
> Comment on attachment 715042 [details] [diff] [review]
> Patch
> 
> Review of attachment 715042 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, thanks for the patch!

Thanks for the review!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8551e3fd9681

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8551e3fd9681

Comment 6

[Hector Zhao [:hectorz]]

Is it possible for this change to be uplifted to Fx 20? Thanks!

Comment 7

[Alex Keybl [:akeybl]]

(In reply to Hector Zhao [:hectorz] from comment #6)
> Is it possible for this change to be uplifted to Fx 20? Thanks!

This appears to be a longstanding issue, and is therefore not critical. Please use approval-mozilla-aurora/approval-mozilla-beta to request approval.

Comment 8

[Hector Zhao [:hectorz]]

(In reply to Alex Keybl [:akeybl] from comment #7)> 
> This appears to be a longstanding issue, and is therefore not critical.
> Please use approval-mozilla-aurora/approval-mozilla-beta to request approval.

Sorry I was not familiar with the implications of the tracking flags, thanks for clarification.

We still want this in Fx 20 for users in China, so I'll request beta approval next week.

Comment 9

[Hector Zhao [:hectorz]]

Comment on attachment 715042 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
Bug 491947, which accidentally revert changes in bug 540537

User impact if declined:
On Windows XP, users who previously set some (Chinese) IE clones as their default browser cannot properly change their default browser to Firefox

Testing completed (on m-c, etc.):
Landed in m-c for more than a week, and already rode the train to m-a

Risk to taking this patch (and alternatives if risky):
Low risk, reintroduction of old behavior

String or UUID changes made by this patch:
None

Comment 10

[Hector Zhao [:hectorz]]

Hi, I don't have commit access yet, what should I do (likt setting some flag) to get this landed on mozilla-beta? Thanks!

Comment 11

[:Gavin Sharp [email: [e-mail]]]

You can mark the bug with the "checkin-needed" keyword.

Comment 12

[Hector Zhao [:hectorz]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #11)
> You can mark the bug with the "checkin-needed" keyword.

Thanks!

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5b7057bb7ae7

Comment 14

[Virgil Dicu [:virgil] [QA]]

I tried to verify the original issue for Firefox 20.0 Beta 2 Zn-Ch (20130227063501) but with no success.

I set 360 browser 3.1 and then Sogou browser 4.0 as default, navigate some websites, opened some links and then I set Firefox 20.0 Beta 2 as default browser. 
External links (e.g. from skype) were opened in Firefox, as expected, so I could not reproduce the initial issue. 

Maybe Lingfeng.Guan, reporter from bug 540537, can help us reproduce this.

Comment 15

[Yanfang Liu]

(In reply to Virgil Dicu [:virgil] [QA] from comment #14)
> I tried to verify the original issue for Firefox 20.0 Beta 2 Zn-Ch
> (20130227063501) but with no success.
> 
> I set 360 browser 3.1 and then Sogou browser 4.0 as default, navigate some
> websites, opened some links and then I set Firefox 20.0 Beta 2 as default
> browser. 
> External links (e.g. from skype) were opened in Firefox, as expected, so I
> could not reproduce the initial issue. 
> 
> Maybe Lingfeng.Guan, reporter from bug 540537, can help us reproduce this.

It happens only on Windows XP system. I just reproduce it one more time on my system which is :
Windows XP Professional 2002 Service Pack 3

Which operating system you are using ?

Comment 16

[Virgil Dicu [:virgil] [QA]]

(In reply to [e-mail] from comment #15)
 
> Which operating system you are using ?

I verified this on Windows 7 as specified in the bug "Platform" section. I will try to verify also on Windows XP.

Comment 17

[Hector Zhao [:hectorz]]

(In reply to Virgil Dicu [:virgil] [QA] from comment #16)
> I verified this on Windows 7 as specified in the bug "Platform" section. I
> will try to verify also on Windows XP.

Sorry I didn't set it properly when filing the bug.