842341 - Windows builds using make fail

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Robert Longson [:longsonr]]

Builds on Windows using make fail. Only pymake builds succeed.

c:/moz2/mozilla/obj-i686-pc-mingw32/_virtualenv/Scripts/python.exe /c/moz2/mozilla/addon-sdk/copy_source.py /c/moz2/mozilla /c/moz2/mozilla/addon-sdk/source/lib
 ../dist/bin/modules/commonjs >copy_source.mk
make -f copy_source.mk libs
make[1]: Entering directory `/c/moz2/mozilla/obj-i686-pc-mingw32/addon-sdk'
c:/moz2/mozilla/config/baseconfig.mk:20: *** Windows-style srcdir being used with GNU make. Did you mean to run c:/moz2/mozilla/build/pymake/make.py instead? [see-also:     https://developer.mozilla.org/en/Gmake_vs._Pymake].  Stop.
make[1]: Leaving directory `/c/moz2/mozilla/obj-i686-pc-mingw32/addon-sdk'
make: *** [libs] Error 2

Comment 1

[(not currently active) Ted Mielczarek]

We should just fix bug 828317 and call this WONTFIX.

Comment 2

[Justin Wood (:Callek)]

Point of reference, SeaMonkey hasn't switched to pymake in our builders yet officially.

So if there is an easy fix here, I'd love to see it. (Yes I know 828317 is around the corner)

Comment 3

[(not currently active) Ted Mielczarek]

I'd rather just rip the band-aid off, honestly, so we can stop having to fix silly things like this.

Comment 4

[Gregory Szorc [:gps]]

Attachment: Use UNIX style paths with GNU make on Windows, v1

This is oh so hacky. But, it only needs to be a stop-gap until we deprecate GNU make on Windows.

As it turns out, msys and/or Python is normalizing path-like command line arguments and environment variables to Windows style. Sigh.

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 716739 [details] [diff] [review]
Use UNIX style paths with GNU make on Windows, v1

Review of attachment 716739 [details] [diff] [review]:
-----------------------------------------------------------------

Lame.

Comment 6

[Gregory Szorc [:gps]]

Do we still need this for SeaMonkey? Or, can we finally kill GNU make on Windows and make this WONTFIX?

Comment 7

[Justin Wood (:Callek)]

I would appreciate an aurora-landing of this, but we don't need it on trunk, and we *can* survive without this on aurora now.

Comment 8

[Gregory Szorc [:gps]]

Well, we can't kill pymake yet because of l10n. It's always l10n. So, landing this as a stop-gap.

https://hg.mozilla.org/integration/mozilla-inbound/rev/0887088eee1a

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0887088eee1a