Closed Bug 842341 Opened 8 years ago Closed 8 years ago
Windows builds using make fail
Builds on Windows using make fail. Only pymake builds succeed. c:/moz2/mozilla/obj-i686-pc-mingw32/_virtualenv/Scripts/python.exe /c/moz2/mozilla/addon-sdk/copy_source.py /c/moz2/mozilla /c/moz2/mozilla/addon-sdk/source/lib ../dist/bin/modules/commonjs >copy_source.mk make -f copy_source.mk libs make: Entering directory `/c/moz2/mozilla/obj-i686-pc-mingw32/addon-sdk' c:/moz2/mozilla/config/baseconfig.mk:20: *** Windows-style srcdir being used with GNU make. Did you mean to run c:/moz2/mozilla/build/pymake/make.py instead? [see-also: https://developer.mozilla.org/en/Gmake_vs._Pymake]. Stop. make: Leaving directory `/c/moz2/mozilla/obj-i686-pc-mingw32/addon-sdk' make: *** [libs] Error 2
We should just fix bug 828317 and call this WONTFIX.
Point of reference, SeaMonkey hasn't switched to pymake in our builders yet officially. So if there is an easy fix here, I'd love to see it. (Yes I know 828317 is around the corner)
I'd rather just rip the band-aid off, honestly, so we can stop having to fix silly things like this.
This is oh so hacky. But, it only needs to be a stop-gap until we deprecate GNU make on Windows. As it turns out, msys and/or Python is normalizing path-like command line arguments and environment variables to Windows style. Sigh.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Attachment #716739 - Flags: review?(ted)
Comment on attachment 716739 [details] [diff] [review] Use UNIX style paths with GNU make on Windows, v1 Review of attachment 716739 [details] [diff] [review]: ----------------------------------------------------------------- Lame.
Attachment #716739 - Flags: review?(ted) → review+
Do we still need this for SeaMonkey? Or, can we finally kill GNU make on Windows and make this WONTFIX?
I would appreciate an aurora-landing of this, but we don't need it on trunk, and we *can* survive without this on aurora now.
Well, we can't kill pymake yet because of l10n. It's always l10n. So, landing this as a stop-gap. https://hg.mozilla.org/integration/mozilla-inbound/rev/0887088eee1a
Target Milestone: --- → mozilla22
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.