842463 - Crash with SVG filter not in a document

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase (crashes Firefox when loaded)

Regression from http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5e137a87e84f&tochange=524e7bc67431 (bug 837044?)

Did https://hg.mozilla.org/mozilla-central/rev/547bfb2239d1#l13.27 remove a null check?

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Scoobidiver (away)]

On Windows: bp-7d4b03c5-6105-47df-9168-06a102130219

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: patch

(In reply to Jesse Ruderman from comment #0)
> Did https://hg.mozilla.org/mozilla-central/rev/547bfb2239d1#l13.27 remove a
> null check?

Yes, do_QueryInterface is null safe. Well spotted.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 715456 [details] [diff] [review]
patch

r=me

Comment 5

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/451dd3f18ba5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/451dd3f18ba5

Comment 7

[Robert Longson [:longsonr]]

Shouldn't this go to Aurora too?

Comment 8

[Jonathan Watt [:jwatt]]

Comment on attachment 715456 [details] [diff] [review]
patch

(In reply to Robert Longson from comment #7)
> Shouldn't this go to Aurora too?

Yes, thanks.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 837044
User impact if declined: potential for crashes
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): virtually no risk
String or UUID changes made by this patch: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/89ec230f063b