Closed Bug 842693 Opened 11 years ago Closed 11 years ago

Add various search options that reviewer tools need to search API

Categories

(Marketplace Graveyard :: Search, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
2013-04-04

People

(Reporter: robhudson, Assigned: robhudson)

References

Details

(Whiteboard: [fireplace] p=3)

Currently the search API only supports:
* Category
* Sorting by: Popularity, Weekly Downloads, Top Rated, Price, Newest

For reviewer tools we need to add:
* query
* device type
* premium type
* flags (has reviewer comment, information requested)
* days since submission
* addon type
* sorting by: name, wait time

I plan on adding these one by one so the code reviews are easy and I can make steady progress.

Once this is done, we can hook up the reviewer tools search to this API.
Blocks: 833500
Priority: -- → P2
Whiteboard: p=3
Added app_type. This replaces "is_packaged" in the API app resource results and will also be the future home of app_type=privileged once we start tracking that.

https://github.com/robhudson/zamboni/commit/ced92cf 

This commit also refactors the tests a little to test the filters and not hit ES.
Made app_type ok for anonymous users:
https://github.com/mozilla/zamboni/commit/414c771e

Added status filter for admins/reviewers:
https://github.com/mozilla/zamboni/commit/8bdd5dd4
Whiteboard: p=3 → p=3 [fireplace]
Whiteboard: p=3 [fireplace] → p=3
Whiteboard: p=3 → p=3 [fireplace]
Depends on: 848445
Depends on: 848446
Add addon_type filter:
https://github.com/mozilla/zamboni/commit/6e7ddcc 

The next 2 require extra data in the ES index:
* nomination date for days since submission (bug 848445), and
* reviewer flags (bug 848446)
Whiteboard: p=3 [fireplace] → [fireplace] p=3
No longer depends on: 848445
No longer depends on: 848446
We don't really need this bug open as a tracker bug. The 2 remaining fields are listed in comment 7. Closing.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2013-04-04
Blocks: 859511
You need to log in before you can comment on or make changes to this bug.