Closed Bug 842870 Opened 11 years ago Closed 11 years ago

Tracking bug for 29-oct-2013 migration work

Categories

(Release Engineering :: General, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: joduinn, Assigned: rail)

References

Details

Attachments

(4 files, 1 obsolete file)

Found in triage.
Component: Release Engineering → Release Engineering: Releases
QA Contact: bhearsum
This is not release work - migration bugs track config.py migrations.
Component: Release Engineering: Releases → Release Engineering: Automation (General)
QA Contact: bhearsum → catlee
Product: mozilla.org → Release Engineering
Depends on: asan-tests
Depends on: 880273
Depends on: 891973, 885456
Depends on: 917433
Assignee: nobody → rail
Blocks: 916209, 918812
Attached patch clean up configsSplinter Review
A noop cleanup:
* replace a loop with items_before() loop
* remove duplicate loop for linux64-asan and invalid platforms (linux64-dbg-asan and linux64-dbg-st-an)

zero diff for config.py dumps
Attachment #817871 - Flags: review?(bhearsum)
Comment on attachment 817871 [details] [diff] [review]
clean up configs

Review of attachment 817871 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla/config.py
@@ +2193,5 @@
>          BRANCHES[branch]['platforms'][platform]['slaves'] = oldslaves
>          if 'l10n_slaves' in BRANCHES[branch]['platforms'][platform] and branch != 'mozilla-esr17':
>              BRANCHES[branch]['platforms'][platform]['l10n_slaves'] = oldslaves
>  
>  # MERGE DAY - Once gecko 26 reaches 'mozilla-release' remove this line

Do we really need these comments when using items_before?
Attachment #817871 - Flags: review?(bhearsum) → review+
Comment on attachment 817871 [details] [diff] [review]
clean up configs

(In reply to Ben Hearsum [:bhearsum] from comment #4)
> Do we really need these comments when using items_before?

No. I removed them:
https://hg.mozilla.org/build/buildbot-configs/rev/8181d7ab7631
Attachment #817871 - Flags: checked-in+
Attachment #819051 - Flags: review?(bhearsum)
Attachment #819051 - Flags: review?(bhearsum) → review+
In production
Attached patch beta + aurora + b2g26_v1_2 (obsolete) — Splinter Review
Phew... It took almost a day of my life!

Since we have to do the uplift and add v1.2 branch at the same time I created a patch with has ALL THE THINGS. :)
Attachment #821921 - Flags: review?(aki)
Comment on attachment 821921 [details] [diff] [review]
beta + aurora + b2g26_v1_2

>diff --git a/mozilla/b2g_config.py b/mozilla/b2g_config.py
>--- a/mozilla/b2g_config.py
>+++ b/mozilla/b2g_config.py
>@@ -804,29 +804,30 @@ PLATFORM_VARS = {
> }
>
>
> # All branches (not in project_branches) that are to be built MUST be listed here, along with their
> # platforms (if different from the default set).
> BRANCHES = {
>     'mozilla-central': {
>     },
>-    'mozilla-aurora': {
>-    },
>     'mozilla-b2g18': {
>         'gecko_version': 18,
>     },
>     'mozilla-b2g18_v1_0_1': {
>         'gecko_version': 18,
>         'b2g_version': (1, 0, 1),
>     },
>     'mozilla-b2g18_v1_1_0_hd': {
>         'gecko_version': 18,
>         'b2g_version': (1, 1, 0),
>     },
>+    'mozilla-b2g26_v1_2': {
>+        'gecko_version': 26,
>+    },

should we set the b2g_version to (1, 2, 0) here?
I don't know if we use b2g_version yet.
Attachment #821921 - Flags: review?(aki) → review+
Comment on attachment 821921 [details] [diff] [review]
beta + aurora + b2g26_v1_2

Oops, ValueError: Cannot shorten "b2g_mozilla-b2g26_v1_2_emulator-debug_dep" to maximum length (30). Got to: b2g_m-b2g26_v1_2_emulator-d_dep
If you don't see the errors, this might not be needed.  Fixed up test-masters.sh for me, though.
Attachment #821959 - Flags: review?(rail)
Attachment #821959 - Flags: review?(rail) → review+
* addressed comments
* refreshed
* carry over r=aki
Attachment #821921 - Attachment is obsolete: true
Attachment #823308 - Flags: review+
Depends on: 931832
in production
Status: NEW → RESOLVED
Closed: 11 years ago
Depends on: 933938
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: