The default bug view has changed. See this FAQ.

SeaMonkey Windows builds are broken due to regression in disable-webRTC

RESOLVED FIXED in seamonkey2.19

Status

SeaMonkey
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ewong, Assigned: ewong)

Tracking

({regression})

Trunk
seamonkey2.19
x86
Windows Vista
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
Windows building with --disable-webRTC breaks with the following 
errors:


WMFUtils.obj : error LNK2001: unresolved external symbol _CLSID_CMP3DecMediaObject

WMFUtils.obj : error LNK2001: unresolved external symbol _CLSID_CMSH264DecoderMFT

xul.dll : fatal error LNK1120: 2 unresolved externals
(Assignee)

Updated

4 years ago
Summary: Windows builds are broken due to regression in disable-webRTC → SeaMonkey Windows builds are broken due to regression in disable-webRTC
(Assignee)

Comment 1

4 years ago
Created attachment 715892 [details] [diff] [review]
Disable webRTC on MacOSX only. (v1)
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #715892 - Flags: review?(bugspam.Callek)
(Assignee)

Comment 2

4 years ago
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/945662d34d67
(Assignee)

Updated

4 years ago
Blocks: 842920
Comment on attachment 715892 [details] [diff] [review]
Disable webRTC on MacOSX only. (v1)

Review of attachment 715892 [details] [diff] [review]:
-----------------------------------------------------------------

As far as I know, this was fixed upstream. Lets back this out (once we are sure we have green first, so we can sanity check).
Attachment #715892 - Flags: review?(bugspam.Callek) → review-
(Assignee)

Comment 4

4 years ago
(In reply to Justin Wood (:Callek) from comment #3)
> Comment on attachment 715892 [details] [diff] [review]
> Disable webRTC on MacOSX only. (v1)
> 
> Review of attachment 715892 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> As far as I know, this was fixed upstream. Lets back this out (once we are
> sure we have green first, so we can sanity check).

Patch has been backed out:
http://hg.mozilla.org/comm-central/rev/ae219d0a01c8
mkato, cpearce, 

So apparantly the patch in 839031 wasn't enough to fix this (our backout caused us to burn in exactly the same way again).

Can we work to figure out a proper fix? -- Remember this issue exists on aurora as well, where right now we have no WebRTC coverage due to this bug.
Flags: needinfo?(m_kato)
Flags: needinfo?(cpearce)
...:

symbols.def : error LNK2001: unresolved external symbol vpx_codec_vp8_cx

NEXT ERROR gkmedias.lib : fatal error LNK1120: 1 unresolved externals
(In reply to Justin Wood (:Callek) from comment #5)
> where right now we have no WebRTC coverage due to this bug.

I should wake up before typing in bugs... right now we have inconsistent WebRTC coverage across platforms due to this bug (we have WebRTC off on mac due to one bug, and on on Windows due to this one, we'd much prefer to have a consistent story regarding our web-features)

Comment 8

4 years ago
Appears to be a regression from Bug 799069 (Unresolved vpx_codec_vp8_cx export in --disable-webrtc build)

http://hg.mozilla.org/mozilla-central/annotate/c233837cce08/layout/media/symbols.def.in#l43

43 #ifdef MOZ_VP8_ENCODER
44 vpx_codec_vp8_cx
45 #endif
Keywords: regression
What Philip Chee said. The Windows Media Foundation video backend doesn't use vpx_codec_vp8_cx, this must be bustage in --disable-webrtc somehow.
Flags: needinfo?(cpearce)

Updated

4 years ago
Flags: needinfo?(m_kato) → needinfo?(rjesup)
WebRTC uses vpx_codec_vp8_cx in media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc.  Why MOZ_VP8_ENCODER=1 with --disable-webrtc?
(In reply to Makoto Kato from comment #10)
> WebRTC uses vpx_codec_vp8_cx in
> media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc.  Why
> MOZ_VP8_ENCODER=1 with --disable-webrtc?

We're not setting MOZ_VP8_ENCODER=1, the issue is the (non seamonkey) code is wrongly doing this.
(In reply to Justin Wood (:Callek) from comment #11)
> (In reply to Makoto Kato from comment #10)
> > WebRTC uses vpx_codec_vp8_cx in
> > media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc.  Why
> > MOZ_VP8_ENCODER=1 with --disable-webrtc?
> 
> We're not setting MOZ_VP8_ENCODER=1, the issue is the (non seamonkey) code
> is wrongly doing this.

To prove this, I'm pushing said WebRTC disabling for Firefox to try right now, for a windows only build, We should expect this same error to appear:

https://tbpl.mozilla.org/?tree=Try&rev=b6967106243c
Hrm, using my releng-access I can see the Firefox build is beyond the point of the issue, and I also now see a newer SeaMonkey build that built gkmedias.dll properly. I actually now suspect the issue here was clobber-needed. :/ (even though I thought I clobbered)

ewong has a push to c-c try for doing this patch for TB, where if its green we'll resolve this bug. Sorry for the churn guys.
Flags: needinfo?(rjesup)

Comment 14

4 years ago
Try run for b6967106243c is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b6967106243c
Results (out of 1 total builds):
    success: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/Callek@gmail.com-b6967106243c
Does symbols.def need dependency of $(GLOBAL_DEPS) if resolved by clobber?
Created attachment 718238 [details] [diff] [review]
fix to update symbol.def correctly

Updated

4 years ago
Attachment #718238 - Flags: review?(ted)
Attachment #718238 - Flags: review?(ted) → review+
landed for symbols.def to m-i.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5df355dff81c
https://hg.mozilla.org/mozilla-central/rev/5df355dff81c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.19
You need to log in before you can comment on or make changes to this bug.