Closed
Bug 842961
Opened 11 years ago
Closed 11 years ago
Ensure we do not restart in safe mode after a crash
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [mozmill-1.5.21+])
Attachments
(1 file)
|
815 bytes,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
In Mozbase master a couple of new preferences are set by default for a better automation experience. We should sync them with the ones we have for mozmill 1.5.
|
Assignee | |
Comment 1•11 years ago
|
||
Looks like there is only a single pref which hasn't been made it into mozrunner 2.x for Mozmill 1.5. It sounds major to me when it comes to crashes during the test run.
Severity: normal → major
OS: Mac OS X → All
Hardware: x86 → All
Summary: Update default preferences for Mozmill 1.5 from mozbase (master) → Ensure we do not restart in safe mode after a crash
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [mozmill-1.5]
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #715970 -
Flags: review?(jhammel)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 715970 [details] [diff] [review] Patch v1 Ultimately preferences are going to be distributed as per bug 830430 , but in the interim this looks like a good fix
Attachment #715970 -
Flags: review?(jhammel) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
This patch is for Mozmill 1.5 only and is based on an old version of mozrunner. It's just a backport.
See Also: 830430 →
|
|
Assignee | |
Comment 5•11 years ago
|
||
https://github.com/mozilla/mozmill/commit/6c65e90bcd7b3ac01c2f89e273f2a6a2fa9729f6
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [mozmill-1.5] → [mozmill-1.5.21+]
|
|
Assignee | |
Comment 6•11 years ago
|
||
The last commit landed bustage on the hotfix-1.5 branch. :/ I pushed a follow-up to fix that: https://github.com/mozilla/mozmill/commit/cf745ddadaa98c97d617184205fbbf94a6c8889e
|
||
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•