Closed Bug 842983 Opened 12 years ago Closed 12 years ago

Fix Facebook import test

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(blocking-b2g:tef+, b2g18+ verified, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 verified)

VERIFIED FIXED
blocking-b2g tef+
Tracking Status
b2g18 + verified
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- verified

People

(Reporter: julienw, Assigned: alberto.pastor)

References

Details

(Whiteboard: [NPOTB])

Attachments

(1 file)

I think this is the commit from Bug 835742.
Blocks: 835742
Assignee: nobody → alberto.pastor
Attached file Pointer to PR 8216
Attachment #716064 - Flags: review?(francisco.jordano)
Comment on attachment 716064 [details] Pointer to PR 8216 Travis saying this tests are passing :)
Attachment #716064 - Flags: review?(francisco.jordano) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 716064 [details] Pointer to PR 8216 NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): Regression by fixing other bugs User impact if declined: None Testing completed: Completed Risk to taking this patch (and alternatives if risky): 0 String or UUID changes made by this patch: dd32a75aa766590d1f419f2ee2c773d77001f01fa This is a change for unit test, that were broken again in a different patch .... hopefully we don't break the tests again
Attachment #716064 - Flags: approval-gaia-v1?
Comment on attachment 716064 [details] Pointer to PR 8216 Approving for v1-train uplift.
Attachment #716064 - Flags: approval-gaia-v1? → approval-gaia-v1+
Summary: Disable Facebook import test → Fix Facebook import test
Overholt requests that I mark this as tef ? due to some bugs I found on master : bug 843835 and Bug 843833
blocking-b2g: --- → tef?
(In reply to Naoki Hirata :nhirata from comment #7) > Overholt requests that I mark this as tef ? due to some bugs I found on > master : bug 843835 and Bug 843833 Yep, and because this has already been uplifted.
Okay, test fix only (-> NPOTB).
blocking-b2g: tef? → tef+
Whiteboard: [NPOTB]
(In reply to Alberto Pastor from comment #4) > Finally fixed instead disabled > > https://github.com/mozilla-b2g/gaia/commit/ > dd32a75aa766590d1f419f2ee2c773d77001f01fa FYI, you appended an extra 'a' on the end of that id: dd32a75aa766590d1f419f2ee2c773d77001f01fa vs dd32a75aa766590d1f419f2ee2c773d77001f01f v1-train@4a6e3de v1.0.1@0b79253
No Test Case needed in Moztrap for this issue.
Flags: in-moztrap-
Can you please provide steps to verify this fix - as we will blackbox test from the UI?
Julien Wajsberg if you can Verify this bug out, it would be much appreciated.
Flags: needinfo?(felash)
Keywords: verifyme
I'm not in QA. It's quite simple to test: try to import contacts from the First-Time-Experience app and from the Contacts app.
Flags: needinfo?(felash)
This is verified fixed on the Leo Build ID: 20130426070204 Environmental Variables: Kernel Date: Mar 15 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6c2493de1441 Gaia: c9046a7acef33328977840176ff5574720d2c74c This is also verified fixed on the Inari Build ID: 20130429070204 Environmental Variables: Kernel Date: Feb 21 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/45aa5ba0ed53 Gaia: cf2d4136f0ebc66039637fdbeb72ed184dfbc0f2
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: