842983 - Fix Facebook import test

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Julien Wajsberg [:julienw]]

make tests fail sometimes : see https://travis-ci.org/mozilla-b2g/gaia/builds/4926526

Comment 1

[Julien Wajsberg [:julienw]]

I think this is the commit from Bug 835742.

Comment 2

[alberto.pastor]

Attachment: Pointer to PR 8216

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 716064 [details]
Pointer to PR 8216

Travis saying this tests are passing :)

Comment 4

[alberto.pastor]

Finally fixed instead disabled

https://github.com/mozilla-b2g/gaia/commit/dd32a75aa766590d1f419f2ee2c773d77001f01fa

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 716064 [details]
Pointer to PR 8216

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Regression by fixing other bugs
User impact if declined: None
Testing completed: Completed
Risk to taking this patch (and alternatives if risky): 0
String or UUID changes made by this patch: dd32a75aa766590d1f419f2ee2c773d77001f01fa

This is a change for unit test, that were broken again in a different patch .... hopefully we don't break the tests again

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 716064 [details]
Pointer to PR 8216

Approving for v1-train uplift.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Overholt requests that I mark this as tef ? due to some bugs I found on master :  bug 843835 and Bug 843833

Comment 8

[Andrew Overholt [:overholt]]

(In reply to Naoki Hirata :nhirata from comment #7)
> Overholt requests that I mark this as tef ? due to some bugs I found on
> master :  bug 843835 and Bug 843833

Yep, and because this has already been uplifted.

Comment 9

[Andrew Overholt [:overholt]]

Okay, test fix only (-> NPOTB).

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Alberto Pastor from comment #4)
> Finally fixed instead disabled
> 
> https://github.com/mozilla-b2g/gaia/commit/
> dd32a75aa766590d1f419f2ee2c773d77001f01fa

FYI, you appended an extra 'a' on the end of that id:

dd32a75aa766590d1f419f2ee2c773d77001f01fa vs
dd32a75aa766590d1f419f2ee2c773d77001f01f

v1-train@4a6e3de
v1.0.1@0b79253

Comment 11

[amiller]

No Test Case needed in Moztrap for this issue.

Comment 12

[amiller]

Can you please provide steps to verify this fix - as we will blackbox test from the UI?

Comment 13

[cbarker]

Julien Wajsberg if you can Verify this bug out, it would be much appreciated.

Comment 14

[Julien Wajsberg [:julienw]]

I'm not in QA.

It's quite simple to test: try to import contacts from the First-Time-Experience app and from the Contacts app.

Comment 15

[Sarah Parsons]

This is verified fixed on the Leo Build ID: 20130426070204

Environmental  Variables:
Kernel Date: Mar 15
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6c2493de1441
Gaia: c9046a7acef33328977840176ff5574720d2c74c

This is also verified fixed on the Inari Build ID: 20130429070204

Environmental  Variables:
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/45aa5ba0ed53
Gaia: cf2d4136f0ebc66039637fdbeb72ed184dfbc0f2