Closed Bug 842997 Opened 11 years ago Closed 11 years ago

Make SelectionHelperUI startup entry points json message agnostic

Categories

(Firefox for Metro Graveyard :: Input, defect)

Product:
Firefox for Metro Graveyard
Component:
Input
Platform:
x86_64
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jimm, Assigned: jimm)

References

Details

(Whiteboard: [selection])

Attachments

(1 file)

patch
12.17 KB, patch
fryn
: review+
Details | Diff | Splinter Review 
http://mxr.mozilla.org/mozilla-central/source/browser/metro/base/content/helperui/SelectionHelperUI.js#228

Selection helper currently integrates into the context menu code in BorwserTouchHandler and takes a json message for input. It doesn't really need much of the json data though, and we will want to invoke this in other cases where json input isn't present.

openEditSession, and attachEditSession should take a set of json agnostic params instead to make working with this module simpler.
No longer blocks: 781487
Depends on: 781487
Whiteboard: [selection]
Component: General → Input
Blocks: caret-sel
Attached patch patch — — Splinter Review 

    
  

        Attachment #725931 -
        Flags: review?(fyan)

    
  

        Attachment #725931 -
        Flags: review?(fyan) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/52007e7e1602
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: