Closed Bug 851388 (caret-sel) Opened 7 years ago Closed 7 years ago
Story - Add support for caret selection via touch
Once bug 832957 lands, selection will have improved quite a bit. However those patches do not include caret selection support. STR: 1) open a page with a text area with text in it 2) tap once to set the caret location result: the caret is positioned but there is no metro singular monocle to drag select text displayed.
Assignee: nobody → jmathies
Whiteboard: feature=work → feature=work [selection]
Summary: Add support for caret selection via touch → Story - Add support for caret selection via touch
Whiteboard: feature=work [selection] → feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=8
Whiteboard: feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=8 → feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=20
Whiteboard: feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=20 → feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=20 [selection]
Swapping out epic trackers: this was in app bar, it should be content feature related. (content text selection)
Whiteboard: feature=story c=firefox_app_bar_and_autocomplete u=metro_firefox_user p=20 [selection] → feature=story u=metro_firefox_user c=content_features p=20 [selection]
In testing, please avoid bug 854182. I'll be looking at monocle positioning problems after the soft keyboard comes up once we figure out the right way to handle that. I have revamped tests and some new ones as well, but those bugs don't have to block qa'ing this work.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Juan, you might want to wait for bug 848594 too.
Tested on 2013-03-29 on Nightly built from http://hg.mozilla.org/mozilla-central/rev/8693d1d4c86d - Tested basic caret selection in text areas. When I tap on the text I get a monocle to appear, which I can drag left or right to select text. - I still see problems associated with bug 854182, where depending on where your text area is relative to where the virtual keyboard appears the text area can be hidden. - Caret selection and monocles are dismissed when tapping outside the text area. - I saw both problems mentioned above bug 850673 and bug 855417. I'm verifying the basic story, and I will follow up with the associated defects.
Status: RESOLVED → VERIFIED
Flags: needinfo?(jbecerra) → in-testsuite?
Whiteboard: feature=story u=metro_firefox_user c=content_features p=20 [selection] → feature=story u=metro_firefox_user c=content_features p=20 [selection] status=verified
Went through the following "Story" for iteration #9 with some issues. Used the following build: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-07-09-03-02-04-mozilla-central/ - Went through the story that has been attached without any issues - Went through the original test case from comment 0 without any issues - Went through the test cases added in comment 4 without any issues - Went through the above test cases using "Filled" view without any issues Issues found: - Sporadic OSK when tapping inside text area's (not always appearing) - Created Bug 891688 (issues with caret monocles not always appearing)
User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0 Build ID: 20130808030205 Built from http://hg.mozilla.org/mozilla-central/rev/fd4cf30428b0 Didn't work for me Tested on windows 8 using latest nightly for iteration-11. Followed steps provided in success scenario. When I tapped between "Write something here" I saw one monocle. I dragged to select word, the word was selected. If I one monocle cross other then the behavior is not expected. See attached video at http://youtu.be/QFuVziHhV2Y
You need to log in before you can comment on or make changes to this bug.