843204 - Add UA overrides requested by Everything.me

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Lawrence Mandel [:lmandel] (use needinfo)]

Attachment: UA overrides

Everything.me has requested a number of UA overrides for sites that are included in their index. Everything.me performed QA on these sites and I tested the overrides on an Unagi to verify that they're effective.

Comment 1

[Michael Wu [:mwu]]

Where do I apply this patch? It doesn't work on my gecko tree.

Comment 2

[Jason Smith [:jsmith]]

(In reply to Michael Wu [:mwu] from comment #1)
> Where do I apply this patch? It doesn't work on my gecko tree.

I'm guessing this is probably a Gaia patch.

Comment 3

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Jason Smith [:jsmith] from comment #2)
> (In reply to Michael Wu [:mwu] from comment #1)
> > Where do I apply this patch? It doesn't work on my gecko tree.
> 
> I'm guessing this is probably a Gaia patch.

Correct. The UA override prefs live in Gaia.

Comment 4

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 716079 [details] [diff] [review]
UA overrides

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: 37 sites currently in the Everything.me index will return desktop content - will likely need to be removed from the index. E.me specifically requested the addition of these sites to v1.0.1 and in time for MWC.
Testing completed: I added the overrides manually to my Unagi and verified that each was effective.
Risk to taking this patch (and alternatives if risky): Low risk, a site that is currently broken could potentially remain broken or break in a new way.
String or UUID changes made by this patch: n/A

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Only tef+ bugs are uplifted to v1.0.1 now, so marking this tef+ in order to get this low risk fix uplifted to the correct branches.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 716079 [details] [diff] [review]
UA overrides

No need for approvals anymore, just get an r+

Comment 7

[David Scravaglieri [:scravag]]

Comment on attachment 716079 [details] [diff] [review]
UA overrides

I ask Rik for a || review as 21 is overloaded

Comment 8

[Anthony Ricaud (:rik)]

Comment on attachment 716079 [details] [diff] [review]
UA overrides

Review of attachment 716079 [details] [diff] [review]:
-----------------------------------------------------------------

Good for me.

Comment 9

[Anthony Ricaud (:rik)]

Comment on attachment 716079 [details] [diff] [review]
UA overrides

Review of attachment 716079 [details] [diff] [review]:
-----------------------------------------------------------------

Removing the request for Viven's review. This is simple enough to not require it.

So, this can land.

Comment 10

[Anthony Ricaud (:rik)]

Landed with https://github.com/mozilla-b2g/gaia/commit/e4fb12ad7a5162327162c9592677f1fb0a327b51

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: abc7507
v1.0.1: 668e078

Comment 13

[amiller]

Does not make sense to create a regression issue.

Comment 14

[Cody Roesch [:croesch]]

Can you please provide steps to verify this fix - as we will blackbox test from the UI?

Comment 15

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to croesch from comment #14)
> Can you please provide steps to verify this fix - as we will blackbox test
> from the UI?

The list of UA overrides that were added can be seen in the patch. Each line that starts with a plus ('+') contains a new UA override. To test, open each site for which an override was added in the browser and ensure that mobile content is both served and functional.

Comment 16

[Darren]

If possible it might be better to run a check on this with automation.