843298 - Project Kickoff Form: require explicit public/private choice

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Gervase Markham [:gerv]]

Follow-up to bug 817150, where I said:

Therefore, I propose that instead, rather than having a default, we make the form user make an explicit choice between "project is public" and "project needs to be private", and don't let them submit the form until they've made it. This would hopefully avoid the "I just hit submit and now my confidential info is public" problem which I assume this bug was filed about, while also avoiding the opposite "I, a non-MoCo person, can't see any bugs relating to this new project we are working on" problem.

This choice applies to the master bug only.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Comment 2

[:glob ✱]

Comment on attachment 716198 [details] [diff] [review]
Patch v.1

all the other options are select fields, please make this option a select field too.

> <label for="private">MoCo Confidential</label>
use "Confidential Mozilla Corporation Bug" instead of "MoCo Confidential"

> dependent bugs, e.g. Finance and Sec Review, will be made secure whatever you choose

use "Security Review" instead of "Sec Review"

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 716198 [details] [diff] [review]
Patch v.1

Review of attachment 716198 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/MozProjectReview/web/js/moz_project_review.js
@@ +213,5 @@
> +            }
> +        }
> +
> +        return false;
> +    }

If you convert the group selection input to a <select>, then the above change is not required.

The select should mimic the others.

Select One
Yes
No

Comment 4

[Gervase Markham [:gerv]]

dkl:

(In reply to David Lawrence [:dkl] from comment #3)
> If you convert the group selection input to a <select>, then the above
> change is not required.
> 
> The select should mimic the others.
> 
> Select One
> Yes
> No

That's not trivial, because the "isFilledOut()" function uses blankness to mean "not filled out", but if the user has selected "Public", then the correct value for the "groups" field is actually blank. (If they select Private, then of course the value is "mozilla-corporation-confidential".)

How do you suggest this is handled? It seems to me that using radio buttons and checking for checkedness is actually quite a reasonable solution.

Gerv

Comment 5

[David Lawrence [:dkl]]

(In reply to Gervase Markham [:gerv] from comment #4)
 > That's not trivial, because the "isFilledOut()" function uses blankness to
> mean "not filled out", but if the user has selected "Public", then the
> correct value for the "groups" field is actually blank. (If they select
> Private, then of course the value is "mozilla-corporation-confidential".)
> 
> How do you suggest this is handled? It seems to me that using radio buttons
> and checking for checkedness is actually quite a reasonable solution.
> 
> Gerv

You would just use some JS to fill in the 'groups' hidden with the right value right before submit. If the user has selected something, take the value selected, otherwise if they have not chosen anything (blank value), then it will throw an error. The select field would be named something other than 'groups'.

dkl

Comment 6

[David Lawrence [:dkl]]

Attachment: Patch to select visibility of top level project bug (v1)

Comment 7

[Gervase Markham [:gerv]]

Comment on attachment 753436 [details] [diff] [review]
Patch to select visibility of top level project bug (v1)

Review of attachment 753436 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/MozProjectReview/template/en/default/bug/create/create-moz-project-review.html.tmpl
@@ +59,5 @@
> +        </div>
> +        <select name="visibility" id="visibility">
> +          <option value="">Select One</option>
> +          <option value="public">Public</option>
> +          <option value="private">MoCo Confidentional</option>

"Confidential" :-) Other than that, r=gerv.

Comment 8

[David Lawrence [:dkl]]

Updated test instance for your verification:

https://bugzilla-dev.allizom.org/form.moz.project.review

dkl

Comment 9

[Michael Coates [:mcoates] (acct no longer active)]

Tried to test twice and got this error:


Internal Server Error

The server encountered an internal error and was unable to complete your request.
Error 500

bugzilla.mozilla.org

Comment 10

[David Lawrence [:dkl]]

(In reply to Michael Coates [:mcoates] from comment #9)
> Tried to test twice and got this error:
> 
> 
> Internal Server Error
> 
> The server encountered an internal error and was unable to complete your
> request.
> Error 500
> 
> bugzilla.mozilla.org

Hmm. Works for me.

https://bugzilla-dev.allizom.org/show_bug.cgi?id=843849

What is the data you are entering so that I can try to reproduce?

dkl

Comment 11

[Gervase Markham [:gerv]]

WFM. mcoates: can you try again?

https://bugzilla-dev.allizom.org/form.moz.project.review

Gerv

Comment 12

[Winnie Aoieong [:winnie]]

Tested to see the dropdown for Moco confidential or public and it worked

https://bugzilla-dev.allizom.org/show_bug.cgi?id=916611

Comment 13

[Gervase Markham [:gerv]]

Thanks, winnie. dkl: can we get this committed to BMO?

Gerv

Comment 14

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bmo/4.2
modified extensions/MozProjectReview/template/en/default/bug/create/create-moz-project-review.html.tmpl
modified extensions/MozProjectReview/web/js/moz_project_review.js
Committed revision 9139.