Closed Bug 843313 Opened 8 years ago Closed 8 years ago

Menu items are composed of many views

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 22

People

(Reporter: sriram, Assigned: sriram)

References

Details

Attachments

(4 files)

(OMG! OMG!)
Each menu item row has more than 5 views, even when each of them can be created in a single TextView.
This patch merges the icon with the menu item's text.
Assignee: nobody → sriram
Attachment #716205 - Flags: review?(mark.finkle)
This patch cleans up more/checkmark on the right side to make it a compound drawable.

I am planning to make it a StateListDrawable. There are some issues with that. I will post a patch once I get that working.
Attachment #716206 - Flags: review?(mark.finkle)
Yaay! There's just one textview. Ideally I wanted the attributes to be inside the MenuItemDefault's constructor. Though it can be done, things got more messier. I felt like having it as an XML and using it.

Also Layout<T extends View> would remove the redundant methods that the interface demands, as they are supported by the View anyways.
Attachment #716208 - Flags: review?(mark.finkle)
The more/checkmark is now a StateListDrawable. This is soooo cleaaan :D
From http://cl.ly/image/2n3U3Z0k1O3W to http://cl.ly/image/0a3B2m0Q2L1x
Attachment #716222 - Flags: review?(mark.finkle)
Attachment #716205 - Flags: review?(mark.finkle) → review+
Attachment #716206 - Flags: review?(mark.finkle) → review+
Attachment #716208 - Flags: review?(mark.finkle) → review+
Comment on attachment 716222 [details] [diff] [review]
Part 4: Merge drawables

Kinda tricky
Attachment #716222 - Flags: review?(mark.finkle) → review+
You need to log in before you can comment on or make changes to this bug.