Closed
Bug 843313
Opened 10 years ago
Closed 10 years ago
Menu items are composed of many views
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: sriram, Assigned: sriram)
References
Details
Attachments
(4 files)
7.49 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
7.61 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
13.59 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
9.47 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
(OMG! OMG!) Each menu item row has more than 5 views, even when each of them can be created in a single TextView.
Assignee | ||
Comment 1•10 years ago
|
||
This patch merges the icon with the menu item's text.
Assignee: nobody → sriram
Attachment #716205 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 2•10 years ago
|
||
This patch cleans up more/checkmark on the right side to make it a compound drawable. I am planning to make it a StateListDrawable. There are some issues with that. I will post a patch once I get that working.
Attachment #716206 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 3•10 years ago
|
||
Yaay! There's just one textview. Ideally I wanted the attributes to be inside the MenuItemDefault's constructor. Though it can be done, things got more messier. I felt like having it as an XML and using it. Also Layout<T extends View> would remove the redundant methods that the interface demands, as they are supported by the View anyways.
Attachment #716208 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 4•10 years ago
|
||
The more/checkmark is now a StateListDrawable. This is soooo cleaaan :D From http://cl.ly/image/2n3U3Z0k1O3W to http://cl.ly/image/0a3B2m0Q2L1x
Attachment #716222 -
Flags: review?(mark.finkle)
Updated•10 years ago
|
Attachment #716205 -
Flags: review?(mark.finkle) → review+
Updated•10 years ago
|
Attachment #716206 -
Flags: review?(mark.finkle) → review+
Updated•10 years ago
|
Attachment #716208 -
Flags: review?(mark.finkle) → review+
Comment 5•10 years ago
|
||
Comment on attachment 716222 [details] [diff] [review] Part 4: Merge drawables Kinda tricky
Attachment #716222 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4afe5b64b232 https://hg.mozilla.org/integration/mozilla-inbound/rev/7047fe1649c7 https://hg.mozilla.org/integration/mozilla-inbound/rev/7547bf5fe166 https://hg.mozilla.org/integration/mozilla-inbound/rev/393bed39e9ab
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4afe5b64b232 https://hg.mozilla.org/mozilla-central/rev/7047fe1649c7 https://hg.mozilla.org/mozilla-central/rev/7547bf5fe166 https://hg.mozilla.org/mozilla-central/rev/393bed39e9ab
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•