843313 - Menu items are composed of many views

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

(OMG! OMG!)
Each menu item row has more than 5 views, even when each of them can be created in a single TextView.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 1: Merge icon

This patch merges the icon with the menu item's text.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 2: Cleanup more

This patch cleans up more/checkmark on the right side to make it a compound drawable.

I am planning to make it a StateListDrawable. There are some issues with that. I will post a patch once I get that working.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 3: One TextView

Yaay! There's just one textview. Ideally I wanted the attributes to be inside the MenuItemDefault's constructor. Though it can be done, things got more messier. I felt like having it as an XML and using it.

Also Layout<T extends View> would remove the redundant methods that the interface demands, as they are supported by the View anyways.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 4: Merge drawables

The more/checkmark is now a StateListDrawable. This is soooo cleaaan :D
From http://cl.ly/image/2n3U3Z0k1O3W to http://cl.ly/image/0a3B2m0Q2L1x

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 716222 [details] [diff] [review]
Part 4: Merge drawables

Kinda tricky

Comment 6

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4afe5b64b232
https://hg.mozilla.org/integration/mozilla-inbound/rev/7047fe1649c7
https://hg.mozilla.org/integration/mozilla-inbound/rev/7547bf5fe166
https://hg.mozilla.org/integration/mozilla-inbound/rev/393bed39e9ab

Comment 7

[(PTO May 7-12) Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4afe5b64b232
https://hg.mozilla.org/mozilla-central/rev/7047fe1649c7
https://hg.mozilla.org/mozilla-central/rev/7547bf5fe166
https://hg.mozilla.org/mozilla-central/rev/393bed39e9ab