843557 - Fennec fails to build with Java 7 due to multiple warnings

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Morrison Cole]

Changeset 7547bf5fe166 (https://hg.mozilla.org/integration/mozilla-inbound/rev/7547bf5fe166) added a type parameter to GeckoMenuItem.Layout. This causes Java 7 builds to fail when treating warnings as errors as none of the references to GeckoMenuItem.Layout have defined parameters.

Warnings at:
/mobile/android/base/GeckoMenuItem.java:41
/mobile/android/base/MenuItemActionBar.java:16
/mobile/android/base/MenuItemDefault.java:19

Comment 1

[Sriram Ramasubramanian [:sriram]]

I couldn't install Java 7 on Mac to try this. Could someone with a linux machine fix it? I basically missed the specific types with implementing the interface.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

y u add useless generic?

Comment 3

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 716733 [details] [diff] [review]
Patch

Review of attachment 716733 [details] [diff] [review]:
-----------------------------------------------------------------

If the cast works without using Generics, I am happy with it. :)

Comment 4

[Kartikaya Gupta (email:[e-mail])]

inbound is closed, so tagging for checkin.

Comment 5

[Lucas Rocha (:lucasr)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #2)
> Created attachment 716733 [details] [diff] [review]
> Patch
> 
> y u add useless generic?

Drive-by: some previous patch in GeckoMenuItem seems to assume that the use of generics there makes it ok to cast this Layout interface to View which is not exactly correct. A more complete fix for this warning should probably include adding something like a getView() method to the layout interface (or something similar) and replace all the castings from Layout to View.

Comment 6

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 2: Revert back!

This revert the methods back into interface. /me accepts his fault.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd6989e8a9e0
https://hg.mozilla.org/integration/mozilla-inbound/rev/68d980182fa4

Comment 8

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/cd6989e8a9e0