843367 - Add Thunderbird symbols to symbolication server

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

We've ported the Gecko Profiler to run on Thunderbird, but we're not getting symbols back from the symbol server. Vladan says we just need to add the symbols there.

Comment 1

[Mark Banner (:standard8)]

Which symbol server are we on about? The nightly builds should already be uploading to the main symbol server that is used for crashes, is this server any different?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

(In reply to Mark Banner (:standard8) from comment #1)
> Which symbol server are we on about? The nightly builds should already be
> uploading to the main symbol server that is used for crashes, is this server
> any different?

I think so, yes - if my understanding is correct, there is a symbol server specifically for Snappy work (https://github.com/vdjeric/Snappy-Symbolication-Server/)

Vladan can confirm.

Comment 3

[Vladan Djeric (:vladan)]

The Gecko Profiler on Windows converts PCs in profiles to function names by sending symbolication requests to the SnappySymbolicationServer. The SnappySymbolicationServer just looks up the symbols in the Breakpad .sym files.

Comment 4

[Wayne Mery (:wsmwk)]

Hi Vladan. Do you anticipate this can be completed soonish? :)
This is not blocking development per se, but it is blocking diagnosis of some issues in the field. TIA.

Comment 5

[Vladan Djeric (:vladan)]

The changes now just need to be deployed:

- Pull request for profiler extension change:
https://github.com/bgirard/Gecko-Profiler-Addon/pull/46
- Request to update symbolication server:
https://bugzilla.mozilla.org/show_bug.cgi?id=849708

Comment 6

[Vladan Djeric (:vladan)]

This has been deployed

Comment 7

[Mike Conley (:mconley) (:⚙️)]

\o/

Thank you for your work, Vladan!

The updated add-on can be installed from https://github.com/bgirard/Gecko-Profiler-Addon/blob/master/geckoprofiler.xpi?raw=true