ignore private tabs on fennec when there is no private-browsing permission

RESOLVED FIXED in 1.14

Status

Add-on SDK
General
P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: erikvold, Assigned: ochameau)

Tracking

unspecified
1.14
All
Android
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

the tabs module on fennec should ignore private tabs when they are not supported by the add-on.

Updated

4 years ago
Priority: -- → P1
Blocks: 815897
I'm sorry Alex, I didn't realize I had separated this task from bug 838981, do you think you could take this one on too?
Depends on: 838981
Flags: needinfo?(poirot.alex)
OS: All → Android
Target Milestone: --- → 1.14
(Assignee)

Comment 2

4 years ago
Not until the workweek now. But sure I can take over this bug if there is no emergency.
Flags: needinfo?(poirot.alex)
Cool, I'll leave it assigned to you for now then, if I can get to it before you then I'll let you know.
Assignee: nobody → poirot.alex
Target Milestone: 1.14 → 1.15
(Assignee)

Comment 4

4 years ago
Created attachment 725035 [details]
Pull request 856

Work in progress.
(Assignee)

Comment 5

4 years ago
Comment on attachment 725035 [details]
Pull request 856

Tested, ready for review!

In this patch I'm also removing getContentWindowForTab in favor of getTabContentWindow as they are same functions.
Attachment #725035 - Flags: review?(evold)
Target Milestone: 1.15 → 1.14
Blocks: 852645
Attachment #725035 - Flags: review?(evold) → review+

Comment 6

4 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/e50f0930cd6ff23307a64a8c040cbb7d497abd80
Bug 843438 - ignore private tabs on fennec when there is no private-browsing permission

https://github.com/mozilla/addon-sdk/commit/d3205730f9eeb6d4a7617053880229f5a2e98ef1
Merge pull request #856 from ochameau/fennec-pb-tabs

Fix Bug 843438 - ignore private tabs on fennec when there is no private-browsing permission r=@erikvold

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Comment 7

4 years ago
Commits pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/e50f0930cd6ff23307a64a8c040cbb7d497abd80
Bug 843438 - ignore private tabs on fennec when there is no private-browsing permission

https://github.com/mozilla/addon-sdk/commit/d3205730f9eeb6d4a7617053880229f5a2e98ef1
Merge pull request #856 from ochameau/fennec-pb-tabs
You need to log in before you can comment on or make changes to this bug.