Closed
Bug 843641
Opened 11 years ago
Closed 11 years ago
Tablet tab carat changes direction in portrait mode
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: ibarlow, Unassigned)
References
Details
Attachments
(1 file)
|
2.14 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
With the new two-way tab view, the tab count carat should point down in portrait mode and to the right in landscape mode. It looks like sometimes the carat mistakenly points to the right after rotating your device from landscape to portrait. We should make sure it always points down.
|
||
Comment 1•11 years ago
|
||
Using resource ID is no-op if setting it the same value (even when the underlying image is actually different for each orientation). Setting drawable does the trick.
Attachment #726432 -
Flags: review?(mark.finkle)
|
||
Updated•11 years ago
|
Attachment #726432 -
Flags: review?(mark.finkle) → review+
|
|
||
Comment 2•11 years ago
|
||
Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/90b7e317d56c
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/90b7e317d56c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
|
Assignee | |
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•