843660 - [B2G][Settings][Device Information]: Phone data not veiwable in settings>device information>more information

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Allen Maxwell]

Description:
After updating build from Unagi Build ID 20130220093954 to Unagi Build ID: 20130221070203, OTA, device has missing OS Version, Firmware Revision, Hardware Revision, MAC Address, Platform Version, Build Identifier, and Update Channel.

Repro Steps:
1) Updated, via OTA, from Unagi Build ID 20130220093954 to Unagi Build ID: 20130221070203
2) Go to Settings>Device Information>More Information
3) Observe device information

Expected:
Device information present and viewable

Actual:
Only IMEI, ICCID, and Git Commit data are available

Repro frequency:
100%

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/effe37a77f18
Gaia: bb633c6f2deb829b2f3d5b9e7bac7fa24467d02a

Comment 1

[Allen Maxwell]

Attachment: Screen Shot

Comment 2

[Tony Chung [:tchung]]

flagging for triage, as this is a regression, plus having this data available is useful to the user to report issues back to support line.

Comment 3

[Allen Maxwell]

Verified issue on Flash build, as well

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Also a security issue
 - briefly enable Remote debugging for manual update
 - reboot
 - Remote debugging option not selected in UI; "Ok, it's off!"
 - $ adb lolcat -> fail, Remote debugging is still on

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I don't know why yet, but then this bug occurs we don't call presetPanel() for the transitioning panel.  I incidentally fixed that with what should be an optimization, but it breaks back navigation for another unknown reason.

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This was regressed by attachment 715105 [details] [diff] [review].

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: FIx

I don't quite understand the original patch, but this fixes the bug.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

cjones, does this fix it for l10n languages as well?  or is this an english only bug?

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Simply revert the change made by attachment 715105 [details] [diff] [review] solves the problem. The patch moved the "presetPanel" function from the "loadPanel" function to the "lazyLoad" function, which cause the sub panels not initialized when loaded.

Comment 11

[Etienne Segonzac (:etienne)]

Comment on attachment 716689 [details] [diff] [review]
FIx

Review of attachment 716689 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

I filed bug 844027, because this is madness.

Comment 12

[Etienne Segonzac (:etienne)]

Comment on attachment 716689 [details] [diff] [review]
FIx

Review of attachment 716689 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

I filed bug 844027, because this is madness.

Comment 13

[Etienne Segonzac (:etienne)]

(In reply to Arthur Chen [:arthurcc] from comment #9)
> Simply revert the change made by attachment 715105 [details] [diff] [review]
> solves the problem. The patch moved the "presetPanel" function from the
> "loadPanel" function to the "lazyLoad" function, which cause the sub panels
> not initialized when loaded.

Yep but does the display/sound panels work then?
(with the proposed patch both the display/sound panels and the more info panel works)

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

You are right... revert the patch brakes display/sound panels :(  Let's use the current patch.

Comment 15

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

There's room to be smarter about how we load settings values for undisplayed subpanels, but we critically need to fix this regression.

https://github.com/mozilla-b2g/gaia/commit/0cacf1a7e57baaf5d6698c98a4dd8c7041d8d4ae

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

This patch does not apply on v1-train.  This might work:

cd gaia
git checkout v1-train
git cherry-pick -x 42fc37735805d493499f1f3e92223b9e41d39ae0
<fix merge conflict>

v1.0.1: 42fc37735805d493499f1f3e92223b9e41d39ae0

Comment 17

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

What a mess ... this fix depends on having everything bug 840322 landed :/.

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

looks like all of the required changes were cherry picked to v1.0.1 [1] but not v1-train.  Time to go down the git log rathole!


[1] https://bugzilla.mozilla.org/show_bug.cgi?id=840322#c59

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

So what happened was that all four commits of 840322 landed on v1.0.1 but only three of four were landed on v1-train.  Oddly, this bug is blocking-b2g:-, but was landed on v1.0.1 anyway.  I have confirmed that landing the one commit that's not on v1-train does allow this bug to land cleanly.

I've asked akeybl to clarify what the desired outcome of 840322 is regarding branch landings.

Chris, should I push a delete (i.e. patch -R) on 42fc37735805d493499f1f3e92223b9e41d39ae0 for now?

Comment 20

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I'm very desperate to take 840322 so let's wait for ex-post-facto approval, if something went wrong in the landing.  (/me not sure anymore)

Comment 21

[Allen Maxwell]

All data is now visible except Firmware Revision on:

Unagi Build ID: 20130226070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/819504e27351
Gaia: 823ae4703347ceb585f5d2de764d9d4138a6e892

Comment 22

[Allen Maxwell]

Firmware Revision data not visible as reference in comment 21

Comment 23

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 11205fdbbb2514fa6c052c9a85e2f4c5456b6f6e

Comment 24

[John Ford [:jhford] CET/CEST Berlin Time]

reopening per comment 22

Comment 25

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

was comment 21 testing gaia 1.0.1?  incapacitated by govt work ATM so would appreciate help sorting this out.

Comment 26

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This was broken before bug 840322 landed [1], so it's a separate old regression.  Please file.

[1] https://github.com/mozilla-b2g/gaia/commit/e162592daddad128ebf8d60c0beb564ca6d633c8

Comment 27

[Anshul]

I still don't see this change in v1.0.1, is this not uplifted yet?

Comment 28

[Julien Wajsberg [:julienw] (PTO -> Mar 17)]

it should be : 

$ git branch -a --contains 42fc37735805d493499f1f3e92223b9e41d39ae0
  remotes/b2g/v1.0.1

If you still see the issue could you please file a new bug ? This will help with commits...

Comment 29

[Allen Maxwell]

Resolved all data except "Firmware revision" on unagi build 20130319070203
Refer to https://bugzilla.mozilla.org/show_bug.cgi?id=852755 for firmware revision data