843823 - document last-pb-context-exited event in private-browsing module

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: Documentation, defect, P1)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

There is some documentation here:

https://developer.mozilla.org/en-US/docs/Supporting_per-window_private_browsing

Comment 1

[Will Bamberg [:wbamberg]]

Attachment: a pull request

Sorry Erik, I forgot this one.

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 727018 [details]
a pull request

We should address bug 833171 too I think, I have the same issue with this example which is that the listener will be gc'd early.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/e195d3bfb11c7989e024b46ad6eaa33dc06eb3b3
Bug 843823 - document last-pb-context-exited event in private-browsing module

https://github.com/mozilla/addon-sdk/commit/f1febfbc133e17e6f6c608c19f6eb3c97993fea5
Fix bug 843823 - Fix the last-pb-context-exited example in the documentation

https://github.com/mozilla/addon-sdk/commit/1cbc1deae2820f81920df3beb804e1db18cddd84
Merge pull request #878 from KWierso/843823

Fix bug 843823 - Document last-pb-context-exited event in private browsing module r=@erikvold

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Link to pull request 878

Addressed your review comment for Will, Erik.

Please redirect the review request if you can't get to it because of 839746.

Comment 5

[[github robot]]

Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/f581f37db10f3cd2ffa26bfdf8f660ef04ac8f6b
Merge pull request #878 from KWierso/843823

Fix bug 843823 - Document last-pb-context-exited event in private browsing module r=@erikvold(cherry picked from commit 1cbc1deae2820f81920df3beb804e1db18cddd84)