843827 - Makefile entry missing for MDPI phone

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

A makefile entry for MDPI resource "ic_menu_new_tab.png" is missing. The file is available though. This would crash on MDPI GB phones, as it wouldn't be packed in the APK.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Added to Makefile.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 716794 [details] [diff] [review]
Patch

Request approval for uplift

Comment 3

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/794d30acd4eb

Comment 4

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 716794 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 838807, may be.
User impact if declined: Gingerbread MDPI phones will crash.
Testing completed (on m-c, etc.): Landed in m-i on 02/21
Risk to taking this patch (and alternatives if risky): None. File is present. Entry missing in Makefile.
String or UUID changes made by this patch: None.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/794d30acd4eb

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 716794 [details] [diff] [review]
Patch

Glad this won't ship - approving for uplift.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2b1d71d16ba9
https://hg.mozilla.org/releases/mozilla-beta/rev/b7949f0b7acb