Closed Bug 843827 Opened 10 years ago Closed 10 years ago

Makefile entry missing for MDPI phone

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox20+ fixed, firefox21+ fixed, firefox22+ fixed)

VERIFIED FIXED
Firefox 22
Tracking Status
firefox20 + fixed
firefox21 + fixed
firefox22 + fixed

People

(Reporter: sriram, Assigned: sriram)

Details

Attachments

(1 file)

A makefile entry for MDPI resource "ic_menu_new_tab.png" is missing. The file is available though. This would crash on MDPI GB phones, as it wouldn't be packed in the APK.
Attached patch PatchSplinter Review
Added to Makefile.
Attachment #716794 - Flags: review?(mark.finkle)
Comment on attachment 716794 [details] [diff] [review]
Patch

Request approval for uplift
Attachment #716794 - Flags: review?(mark.finkle) → review+
Comment on attachment 716794 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 838807, may be.
User impact if declined: Gingerbread MDPI phones will crash.
Testing completed (on m-c, etc.): Landed in m-i on 02/21
Risk to taking this patch (and alternatives if risky): None. File is present. Entry missing in Makefile.
String or UUID changes made by this patch: None.
Attachment #716794 - Flags: approval-mozilla-beta?
Attachment #716794 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/794d30acd4eb
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Comment on attachment 716794 [details] [diff] [review]
Patch

Glad this won't ship - approving for uplift.
Attachment #716794 - Flags: approval-mozilla-beta?
Attachment #716794 - Flags: approval-mozilla-beta+
Attachment #716794 - Flags: approval-mozilla-aurora?
Attachment #716794 - Flags: approval-mozilla-aurora+
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.