Closed
Bug 844186
Opened 11 years ago
Closed 11 years ago
Lock portrait-primary orientation
Categories
(Marketplace Graveyard :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cvan, Assigned: scolville)
References
Details
(Whiteboard: p=1)
No description provided.
Updated•11 years ago
|
Assignee: nobody → scolville
Priority: -- → P2
Whiteboard: p=1
Reporter | ||
Comment 1•11 years ago
|
||
See https://developer.mozilla.org/en-US/docs/Apps/Manifest#orientation
Comment 2•11 years ago
|
||
This is probably going to require modifying the Gaia marketplace preinstalled app as well. Should be an easy one line fix to your manifest though - you just need to set orientation to portrait in the app manifest.
Reporter | ||
Comment 3•11 years ago
|
||
Here: https://github.com/mozilla-b2g/gaia/blob/master/external-apps/marketplace/manifest.webapp
Assignee | ||
Comment 4•11 years ago
|
||
Here's the related PRs. Zamboni: https://github.com/mozilla/zamboni/pull/646 Gaia: https://github.com/mozilla-b2g/gaia/pull/8410
Status: NEW → ASSIGNED
Comment 5•11 years ago
|
||
Nit on process (for how Gaia pull requests work) - you might want to split the Gaia piece into a separate bug, attach a HTML attachment pointing to your github pull request, and ask for reviewer from a Gaia peer (fabrice or vivien are good candidates in this case).
Comment 6•11 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #5) > Nit on process (for how Gaia pull requests work) - you might want to split > the Gaia piece into a separate bug, attach a HTML attachment pointing to > your github pull request, and ask for reviewer from a Gaia peer (fabrice or > vivien are good candidates in this case). You'll also want the nom the associated bug for approval v1 to get this on v1-train.
Comment 7•11 years ago
|
||
Dumb question: why do we want to lock the marketplace into portrait?
Comment 8•11 years ago
|
||
(In reply to Kumar McMillan [:kumar] from comment #7) > Dumb question: why do we want to lock the marketplace into portrait? Because we don't have landscape designs. It's not a trivial effort to make those, and then implement that - and also not a high priority. So instead of letting it look bad until we do landscape we just won't allow it :P
Reporter | ||
Comment 9•11 years ago
|
||
Added to Fireplace: https://github.com/mozilla/fireplace/commit/d75fad2c1
Comment 10•11 years ago
|
||
Per talking with mushi and fabrice - let's actually go with portrait-primary here, not portrait only.
Summary: Lock portrait orientation → Lock portrait-primary orientation
Assignee | ||
Comment 11•11 years ago
|
||
Updated to portrait-primary in Fireplace: https://github.com/mozilla/fireplace/commit/59330dcda6cf3e6020778b0c0b775ee9c633b728
Assignee | ||
Comment 12•11 years ago
|
||
https://github.com/mozilla/zamboni/commit/9e0d9a4ba1aa5d4895ef2be60d660a9aacfd6b3a
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•11 years ago
|
Status: REOPENED → ASSIGNED
Assignee | ||
Comment 13•11 years ago
|
||
Awaiting 846831 to land.
Comment 14•11 years ago
|
||
Looks like that landed.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•