844186 - Lock portrait-primary orientation

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect, P2)

Comment 1

[Christopher Van Wiemeersch [:cvan]]

See https://developer.mozilla.org/en-US/docs/Apps/Manifest#orientation

Comment 2

[Jason Smith [:jsmith]]

This is probably going to require modifying the Gaia marketplace preinstalled app as well. 

Should be an easy one line fix to your manifest though - you just need to set orientation to portrait in the app manifest.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Here: https://github.com/mozilla-b2g/gaia/blob/master/external-apps/marketplace/manifest.webapp

Comment 4

[Stuart Colville [:muffinresearch]]

Here's the related PRs.

Zamboni: https://github.com/mozilla/zamboni/pull/646
Gaia: https://github.com/mozilla-b2g/gaia/pull/8410

Comment 5

[Jason Smith [:jsmith]]

Nit on process (for how Gaia pull requests work) - you might want to split the Gaia piece into a separate bug, attach a HTML attachment pointing to your github pull request, and ask for reviewer from a Gaia peer (fabrice or vivien are good candidates in this case).

Comment 6

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #5)
> Nit on process (for how Gaia pull requests work) - you might want to split
> the Gaia piece into a separate bug, attach a HTML attachment pointing to
> your github pull request, and ask for reviewer from a Gaia peer (fabrice or
> vivien are good candidates in this case).

You'll also want the nom the associated bug for approval v1 to get this on v1-train.

Comment 7

[Kumar McMillan [:kumar]]

Dumb question: why do we want to lock the marketplace into portrait?

Comment 8

[Maria Sandberg [:mushi]]

(In reply to Kumar McMillan [:kumar] from comment #7)
> Dumb question: why do we want to lock the marketplace into portrait?

Because we don't have landscape designs. It's not a trivial effort to make those, and then implement that - and also not a high priority. So instead of letting it look bad until we do landscape we just won't allow it :P

Comment 9

[Christopher Van Wiemeersch [:cvan]]

Added to Fireplace: https://github.com/mozilla/fireplace/commit/d75fad2c1

Comment 10

[Jason Smith [:jsmith]]

Per talking with mushi and fabrice - let's actually go with portrait-primary here, not portrait only.

Comment 11

[Stuart Colville [:muffinresearch]]

Updated to portrait-primary in Fireplace: https://github.com/mozilla/fireplace/commit/59330dcda6cf3e6020778b0c0b775ee9c633b728

Comment 12

[Stuart Colville [:muffinresearch]]

https://github.com/mozilla/zamboni/commit/9e0d9a4ba1aa5d4895ef2be60d660a9aacfd6b3a

Comment 13

[Stuart Colville [:muffinresearch]]

Awaiting 846831 to land.

Comment 14

[Matt Basta [:basta]]

Looks like that landed.