Last Comment Bug 844186 - Lock portrait-primary orientation
: Lock portrait-primary orientation
Status: RESOLVED FIXED
p=1
:
Product: Marketplace
Classification: Server Software
Component: General (show other bugs)
: 1.0
: All All
: P2 normal (vote)
: ---
Assigned To: Stuart Colville [:scolville] [:muffinresearch]
:
:
Mentors:
Depends on: 846831
Blocks: 832096
  Show dependency treegraph
 
Reported: 2013-02-22 10:32 PST by Christopher Van Wiemeersch [:cvan]
Modified: 2013-03-06 10:30 PST (History)
6 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Description Christopher Van Wiemeersch [:cvan] 2013-02-22 10:32:46 PST

    
Comment 1 Christopher Van Wiemeersch [:cvan] 2013-02-27 10:50:51 PST
See https://developer.mozilla.org/en-US/docs/Apps/Manifest#orientation
Comment 2 Jason Smith [:jsmith] 2013-02-28 10:09:34 PST
This is probably going to require modifying the Gaia marketplace preinstalled app as well. 

Should be an easy one line fix to your manifest though - you just need to set orientation to portrait in the app manifest.
Comment 3 Christopher Van Wiemeersch [:cvan] 2013-02-28 13:26:55 PST
Here: https://github.com/mozilla-b2g/gaia/blob/master/external-apps/marketplace/manifest.webapp
Comment 4 Stuart Colville [:scolville] [:muffinresearch] 2013-03-01 09:22:30 PST
Here's the related PRs.

Zamboni: https://github.com/mozilla/zamboni/pull/646
Gaia: https://github.com/mozilla-b2g/gaia/pull/8410
Comment 5 Jason Smith [:jsmith] 2013-03-01 09:25:28 PST
Nit on process (for how Gaia pull requests work) - you might want to split the Gaia piece into a separate bug, attach a HTML attachment pointing to your github pull request, and ask for reviewer from a Gaia peer (fabrice or vivien are good candidates in this case).
Comment 6 Jason Smith [:jsmith] 2013-03-01 09:33:07 PST
(In reply to Jason Smith [:jsmith] from comment #5)
> Nit on process (for how Gaia pull requests work) - you might want to split
> the Gaia piece into a separate bug, attach a HTML attachment pointing to
> your github pull request, and ask for reviewer from a Gaia peer (fabrice or
> vivien are good candidates in this case).

You'll also want the nom the associated bug for approval v1 to get this on v1-train.
Comment 7 Kumar McMillan [:kumar] (needinfo all the things) 2013-03-01 10:06:56 PST
Dumb question: why do we want to lock the marketplace into portrait?
Comment 8 Maria Sandberg [:mushi] 2013-03-01 10:47:32 PST
(In reply to Kumar McMillan [:kumar] from comment #7)
> Dumb question: why do we want to lock the marketplace into portrait?

Because we don't have landscape designs. It's not a trivial effort to make those, and then implement that - and also not a high priority. So instead of letting it look bad until we do landscape we just won't allow it :P
Comment 9 Christopher Van Wiemeersch [:cvan] 2013-03-01 11:21:51 PST
Added to Fireplace: https://github.com/mozilla/fireplace/commit/d75fad2c1
Comment 10 Jason Smith [:jsmith] 2013-03-04 12:27:14 PST
Per talking with mushi and fabrice - let's actually go with portrait-primary here, not portrait only.
Comment 11 Stuart Colville [:scolville] [:muffinresearch] 2013-03-05 09:13:19 PST
Updated to portrait-primary in Fireplace: https://github.com/mozilla/fireplace/commit/59330dcda6cf3e6020778b0c0b775ee9c633b728
Comment 12 Stuart Colville [:scolville] [:muffinresearch] 2013-03-06 02:28:52 PST
https://github.com/mozilla/zamboni/commit/9e0d9a4ba1aa5d4895ef2be60d660a9aacfd6b3a
Comment 13 Stuart Colville [:scolville] [:muffinresearch] 2013-03-06 02:40:41 PST
Awaiting 846831 to land.
Comment 14 Matt Basta [:basta] 2013-03-06 10:30:58 PST
Looks like that landed.

Note You need to log in before you can comment on or make changes to this bug.