Lock portrait-primary orientation

RESOLVED FIXED

Status

Marketplace
General
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cvan, Assigned: scolville)

Tracking

Points:
---
Dependency tree / graph

Details

(Whiteboard: p=1)

Comment hidden (empty)
(Reporter)

Updated

5 years ago
Blocks: 832096
Assignee: nobody → scolville
Priority: -- → P2
Whiteboard: p=1
(Reporter)

Comment 1

5 years ago
See https://developer.mozilla.org/en-US/docs/Apps/Manifest#orientation
This is probably going to require modifying the Gaia marketplace preinstalled app as well. 

Should be an easy one line fix to your manifest though - you just need to set orientation to portrait in the app manifest.
(Reporter)

Comment 3

5 years ago
Here: https://github.com/mozilla-b2g/gaia/blob/master/external-apps/marketplace/manifest.webapp
Here's the related PRs.

Zamboni: https://github.com/mozilla/zamboni/pull/646
Gaia: https://github.com/mozilla-b2g/gaia/pull/8410
Status: NEW → ASSIGNED
Nit on process (for how Gaia pull requests work) - you might want to split the Gaia piece into a separate bug, attach a HTML attachment pointing to your github pull request, and ask for reviewer from a Gaia peer (fabrice or vivien are good candidates in this case).
(In reply to Jason Smith [:jsmith] from comment #5)
> Nit on process (for how Gaia pull requests work) - you might want to split
> the Gaia piece into a separate bug, attach a HTML attachment pointing to
> your github pull request, and ask for reviewer from a Gaia peer (fabrice or
> vivien are good candidates in this case).

You'll also want the nom the associated bug for approval v1 to get this on v1-train.
Dumb question: why do we want to lock the marketplace into portrait?
(In reply to Kumar McMillan [:kumar] from comment #7)
> Dumb question: why do we want to lock the marketplace into portrait?

Because we don't have landscape designs. It's not a trivial effort to make those, and then implement that - and also not a high priority. So instead of letting it look bad until we do landscape we just won't allow it :P
(Reporter)

Comment 9

5 years ago
Added to Fireplace: https://github.com/mozilla/fireplace/commit/d75fad2c1
Depends on: 846831
Per talking with mushi and fabrice - let's actually go with portrait-primary here, not portrait only.
Summary: Lock portrait orientation → Lock portrait-primary orientation
Updated to portrait-primary in Fireplace: https://github.com/mozilla/fireplace/commit/59330dcda6cf3e6020778b0c0b775ee9c633b728
https://github.com/mozilla/zamboni/commit/9e0d9a4ba1aa5d4895ef2be60d660a9aacfd6b3a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Awaiting 846831 to land.

Comment 14

5 years ago
Looks like that landed.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.