Closed
Bug 846831
Opened 12 years ago
Closed 12 years ago
Lock bundled marketplace app orientation to portrait-primary
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: muffinresearch, Assigned: muffinresearch)
References
Details
Attachments
(1 file)
Update the bundled marketplace app manifest to lock to portrait as per Bug 844186
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → scolville
Status: NEW → ASSIGNED
|
||
Comment 2•12 years ago
|
||
Attachment #720699 -
Flags: review?(fabrice)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 720699 [details]
Pointer to Github Pull Request: https://github.com/mozilla-b2g/gaia/pull/8410
All other gaia apps use "portrait-primary" and not "portrait". Is there any reason to not do the same here?
Attachment #720699 -
Flags: review?(fabrice)
|
|
||
Comment 5•12 years ago
|
||
Talked with mushi in IRC - let's actually go with portrait-primary here. It falls in better alignment with other gaia apps and still meets the requirement to not have the marketplace app in landscape mode.
Flags: needinfo?(msandberg)
|
|
||
Updated•12 years ago
|
Summary: Lock bundled marketplace app orientation to portrait. → Lock bundled marketplace app orientation to portrait-primary
|
|
Assignee | |
Comment 6•12 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #5)
> Talked with mushi in IRC - let's actually go with portrait-primary here. It
> falls in better alignment with other gaia apps and still meets the
> requirement to not have the marketplace app in landscape mode.
The PR has been updated - it's now portrait-primary.
|
|
||
Comment 7•12 years ago
|
||
Comment on attachment 720699 [details]
Pointer to Github Pull Request: https://github.com/mozilla-b2g/gaia/pull/8410
Looks fine on my end. Sending over to Fabrice for review.
Attachment #720699 -
Flags: review?(fabrice)
Attachment #720699 -
Flags: feedback+
|
|
||
Comment 8•12 years ago
|
||
Comment on attachment 720699 [details]
Pointer to Github Pull Request: https://github.com/mozilla-b2g/gaia/pull/8410
r=me, thanks! Please amend the commit message to include r=fabrice before merging
Attachment #720699 -
Flags: review?(fabrice) → review+
|
|
Assignee | |
Comment 9•12 years ago
|
||
Ok the commit message is updated and it's ready to go - (I don't have the commit bit).
|
|
||
Updated•12 years ago
|
Keywords: checkin-needed
|
|
||
Comment 10•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 11•12 years ago
|
||
since Bug 856799 is adding the manifest to a package now, this bug will land "automatically" on v1-train and v1.0.1 too.
You need to log in
before you can comment on or make changes to this bug.
Description
•