844462 - HTMLFrameElement.mozbrowser is no longer exposed

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:ehsan akhgari]

See the test case in URL.  Trunk returns undefined, but before we used to return false.

This is because bug 838343 did not expose nsIDOMMozBrowserFrame through the Web IDL interface.

Comment 2

[Boris Zbarsky [:bzbarsky, bz on IRC]]

jlebar said that it was ok to not expose mozbrowser stuff on <frame>.  Is that not the case?

Comment 3

[Justin Lebar (not reading bugmail)]

(In reply to Boris Zbarsky (:bz) from comment #2)
> jlebar said that it was ok to not expose mozbrowser stuff on <frame>.  Is
> that not the case?

I'm not aware of any reason we need it.

Comment 4

[:ehsan akhgari]

Sorry, this has nothing to do with bug 842986.

(In reply to Justin Lebar [:jlebar] from comment #3)
> (In reply to Boris Zbarsky (:bz) from comment #2)
> > jlebar said that it was ok to not expose mozbrowser stuff on <frame>.  Is
> > that not the case?
> 
> I'm not aware of any reason we need it.

OK.  Then I think we need to correct the documentation here <http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/html/nsIDOMMozBrowserFrame.idl> (and perhaps elsewhere) and close this as WONTFIX.

Comment 5

[Andrea Marchesini [:baku]]

Attachment: patch

Is this what you mean?

Comment 6

[:ehsan akhgari]

Comment on attachment 743003 [details] [diff] [review]
patch

Review of attachment 743003 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, thanks!

Comment 7

[:ehsan akhgari]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c74d9bbb0049

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c74d9bbb0049

Comment 9

[j.j.]

The correct resolution should be WONTFIX rather than FIXED (see comment 4)