Closed Bug 844462 Opened 7 years ago Closed 7 years ago

HTMLFrameElement.mozbrowser is no longer exposed

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: ehsan, Assigned: baku)

References

()

Details

Attachments

(1 file)

See the test case in URL.  Trunk returns undefined, but before we used to return false.

This is because bug 838343 did not expose nsIDOMMozBrowserFrame through the Web IDL interface.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 842986
jlebar said that it was ok to not expose mozbrowser stuff on <frame>.  Is that not the case?
(In reply to Boris Zbarsky (:bz) from comment #2)
> jlebar said that it was ok to not expose mozbrowser stuff on <frame>.  Is
> that not the case?

I'm not aware of any reason we need it.
Sorry, this has nothing to do with bug 842986.

(In reply to Justin Lebar [:jlebar] from comment #3)
> (In reply to Boris Zbarsky (:bz) from comment #2)
> > jlebar said that it was ok to not expose mozbrowser stuff on <frame>.  Is
> > that not the case?
> 
> I'm not aware of any reason we need it.

OK.  Then I think we need to correct the documentation here <http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/html/nsIDOMMozBrowserFrame.idl> (and perhaps elsewhere) and close this as WONTFIX.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Attached patch patchSplinter Review
Is this what you mean?
Attachment #743003 - Flags: review?(ehsan)
Comment on attachment 743003 [details] [diff] [review]
patch

Review of attachment 743003 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, thanks!
Attachment #743003 - Flags: review?(ehsan) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c74d9bbb0049
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
The correct resolution should be WONTFIX rather than FIXED (see comment 4)
OS: Mac OS X → All
Hardware: x86 → All
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.