844913 - SwiftKey crashes on Gingerbread when using background IME thread

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

I noticed SwiftKey crashes as soon as we switch from UI thread to the background IME thread, but I've only seen it on Gingerbread.

Comment 1

[Scoobidiver (away)]

Is it related to bug 844020?

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Scoobidiver from comment #1)
> Is it related to bug 844020?

I don't think so. That bug only happens in the Awesomebar and this bug only happens in content.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Null-check getEditable() results in GeckoInputConnection (v1)

The problem is we did not null-check results from GeckoInputConnection.getEditable(), because it used to never return null. Now that we have an IC thread, it can return null if we are running on the UI thread.

This patch adds the necessary null-checks. I went over each case, and determined we can safely ignore the call when getEditable() returns null.

BaseInputConnection ignores the call if getEditable() returns null, so this patch matches Android's behavior as well.

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 718016 [details] [diff] [review]
Null-check getEditable() results in GeckoInputConnection (v1)

Review of attachment 718016 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c862b0b9a898

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c862b0b9a898

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 718016 [details] [diff] [review]
Null-check getEditable() results in GeckoInputConnection (v1)

[Approval Request Comment]

Bug caused by (feature/regressing bug #): Bug 835906

User impact if declined: Crash in SwiftKey not caught by crash reporter

Testing completed (on m-c, etc.): locally; m-c

Risk to taking this patch (and alternatives if risky): Very small; patch only avoids crash

String or UUID changes made by this patch: None

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 718016 [details] [diff] [review]
Null-check getEditable() results in GeckoInputConnection (v1)

low risk patch with a couple of null checks, fixing crash regression.Approving for uplift

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e1951fe80c22