Closed
Bug 844989
Opened 12 years ago
Closed 12 years ago
Replace fedora-b2g slaves with ubuntu64-b2g for b2g emulator test
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
References
Details
Attachments
(1 file, 1 obsolete file)
12.65 KB,
patch
|
mozilla
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
ATM the plan is to replace MOCHITEST + MARIONETTE + XPCSHELL for opt and probably debug builds.
The patch replaces fedora slaves for all branches except b2g18 and b2g18_v1_0_1 (we can discuss this list).
Comment 1•12 years ago
|
||
Was just about to file this :)
The patch to disable the failing mochitests just landed on inbound and I was planning to land it on b2g18 after it gets merged to m-c. That means this patch is pretty much ready to land as soon as it gets reviewed.
Depends on: 843747
Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 718013 [details] [diff] [review]
replace fedora
The patch generates a sane diff for b2g_config.py dump and passed test-masters.sh
Attachment #718013 -
Flags: review?(aki)
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 718013 [details] [diff] [review]
replace fedora
Review of attachment 718013 [details] [diff] [review]:
-----------------------------------------------------------------
::: mozilla-tests/b2g_config.py
@@ +688,3 @@
> for branch in set(BRANCHES.keys()) - set(['cedar']):
> + if branch in NON_UBUNTU_BRANCHES:
> + print "removing", branch
I'll remove the line above, of course.
Comment 4•12 years ago
|
||
Comment on attachment 718013 [details] [diff] [review]
replace fedora
r=me without the print, if the builder_list diff looks good.
Attachment #718013 -
Flags: review?(aki) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 718013 [details] [diff] [review]
replace fedora
I found some issues with the builder names...
Attachment #718013 -
Flags: review+
Assignee | ||
Comment 6•12 years ago
|
||
I found a problem (finally). The patch was trying to to mangle a mutable variable (slave_platforms.remove(...)). Using list(PLATFORMS[platform]['slave_platforms']) fixes it.
I also simplified the "evil" loop because b2g_config.py is simpler than config.py and we already have all ubuntu runable tests listed in platform_config (which can be redefined in branch_config).
Thanks for the tip, builder_list.py has a sane output now.
Attachment #718013 -
Attachment is obsolete: true
Attachment #718235 -
Flags: review?(aki)
Comment 7•12 years ago
|
||
Comment on attachment 718235 [details] [diff] [review]
replace fedora
I'm hoping that these for loops in both b2g_config.py and config.py will go away when we finish the switch over to ubuntu unittests for all suites that we can ?
Attachment #718235 -
Flags: review?(aki) → review+
Assignee | ||
Comment 8•12 years ago
|
||
ahal, do you think that we are ready to go and switch from Fedora to Ubuntu?
Flags: needinfo?(ahalberstadt)
Assignee | ||
Comment 10•12 years ago
|
||
Comment on attachment 718235 [details] [diff] [review]
replace fedora
http://hg.mozilla.org/build/buildbot-configs/rev/8ef764230c91
Attachment #718235 -
Flags: checked-in+
Assignee | ||
Comment 11•12 years ago
|
||
in production
Assignee | ||
Comment 12•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=7bdc94c723f3
B2G Arm (VM) opt M(1 2 3 4 5 6 7 8 9) Mn X
All green.
Kudos (read beer) should go to ahal! :)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 13•12 years ago
|
||
Awesome, many thanks to all involved!
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•