Status

defect
RESOLVED INVALID
7 years ago
2 years ago

People

(Reporter: epang, Assigned: pivanov)

Tracking

({polish})

Dependency tree / graph

Firefox Tracking Flags

(b2g18+ affected)

Details

(Whiteboard: visual design, UX-P1, yedo, landed in uxbranch)

Attachments

(3 attachments, 1 obsolete attachment)

Posted image Sending email screen mock up (obsolete) —
Changes:
1.  Consistent system font treatment
3.  Spinner moved to right of text (to preserve left alignment of type)
No longer depends on: 844615
Blocks: 841512
See attached image for list of changes
Attachment #718099 - Attachment is obsolete: true
Posted file patch for Gaia repo
Attachment #723187 - Flags: review?(sjochimek)
(In reply to Pavel Ivanov [:ivanovpavel] from comment #2)
> Created attachment 723186 [details]
> After patch

Looks good! thx!
Comment on attachment 723187 [details]
patch for Gaia repo

ok according to BB it's a r+ for me.
Attachment #723187 - Flags: review?(sjochimek) → review+
blocking-b2g: --- → koi?
blocking-b2g: koi? → leo?
LG request for font updates.
Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1
tracking-b2g18: --- → +
blocking-b2g: leo? → ---
Whiteboard: visual design, UX-P1, yedo → visual design, UX-P1, yedo, landed in uxbranch
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Not sure why the E is capitalized at the end? 

https://github.com/pivanov/gaia/commit/7e5503db6705894d9c6decc1a602b7f719193c03#L0R1078


Master build : 2013-04-04-03-09-55
name="mozilla-central" revision="c232bec6974d"
name="integration/gaia-central" revision="d50316e8e9b9"
name="gecko.git" revision="4d9b24f0cb7cabfa1ceb4d2953e993e6af3ca1c4"
name="gaia.git" revision="29660ec0a4ad7c90d22e33852e1601d45f781e03"
Status: RESOLVED → VERIFIED
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #8)
> Not sure why the E is capitalized at the end? 

That's not the localized string.  It's a string in the HTML to provide context but make it clear it's not the localized string and that if you're seeing it, we have a localization problem.
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #8)
> Not sure why the E is capitalized at the end? 
> 
> https://github.com/pivanov/gaia/commit/
> 7e5503db6705894d9c6decc1a602b7f719193c03#L0R1078
> 
> 
> Master build : 2013-04-04-03-09-55
> name="mozilla-central" revision="c232bec6974d"
> name="integration/gaia-central" revision="d50316e8e9b9"
> name="gecko.git" revision="4d9b24f0cb7cabfa1ceb4d2953e993e6af3ca1c4"
> name="gaia.git" revision="29660ec0a4ad7c90d22e33852e1601d45f781e03"

Hi Naoki, the capital E isn't seen anywhere and as Andrew said, it's used to provide context.
Hi Eric,
This update was not necesary, can you please explain why are you requesting an updated design? AFAK this is following the specs and using the Building Blocks provided for activity indicators. 
See: http://buildingfirefoxos.com/building-blocks/progress-and-activity/

If you can clarify the need for this change it would be great.
Hi Victoria, I discussed this with Przemek and we agree that this can stay as is.  The reason we updated the design was to try and find a consistent way to display system msgs.  I'll email you with more details soon. Thanks!
Status: VERIFIED → RESOLVED
Closed: 6 years ago6 years ago
Flags: needinfo?
Resolution: FIXED → INVALID
Flags: needinfo?
You need to log in before you can comment on or make changes to this bug.