844615 - Email Layout and Font Revisions - New Account (All done screen)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Before/After Mock ups

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch

Hey Eric,
can I use the same styles like here Bug 844595 - https://bug844595.bugzilla.mozilla.org/attachment.cgi?id=717615

"All done!" will be the same like "Setting up account" (same font-size, same margin-top)?

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for UX branch

Comment 3

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #1)
> Created attachment 717647 [details]
> After patch
> 
> Hey Eric,
> can I use the same styles like here Bug 844595 -
> https://bug844595.bugzilla.mozilla.org/attachment.cgi?id=717615
> 
> "All done!" will be the same like "Setting up account" (same font-size, same
> margin-top)?


yes and no :).  Font size, yes.  But margin wise the content should be centered in the available remaining space. So the "All done" text will be slightly higher because of the space the two buttons take up at the bottom. thx!

Comment 4

[Sam Joch [:samjoch]]

Landed in uxbranch: https://github.com/gordonbrander/gaia/commit/b38d30dded89d134a6f2e4c58e8e087060607d24

Comment 6

[Eric Pang [:epang] UX]

LG request for font updates.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1

Comment 8

[Eric Pang [:epang] UX]

Comment on attachment 717652 [details]
patch for UX branch

Looks like this landed in the old ux branch,  Kevin can you review and land to master?  Thanks!

Comment 9

[Kevin Grandon :kgrandon]

Need some help with this one. There are merge conflicts when trying to bring in this commit.

Pavel - Could you rebase against master and open up a pull request against gaia master?

Comment 10

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia repo

I reabse the patch and move the PR from UX branch to Gaia/master

Comment 11

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Comment 12

[Kevin Grandon :kgrandon]

This has been landed in master: https://github.com/mozilla-b2g/gaia/commit/574c7770ba7e554821cfaa3c7e5f383443269063

Comment 13

[Kevin Grandon :kgrandon]

Comment on attachment 734007 [details]
Github pull request pointer

Low risk UX patch, would be nice to have uplifted.

User impact if declined: Not as nice UX on initial startup screens.
Testing completed: Manual testing (layout changes only)
Risk: Low

Comment 14

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Master build : 2013-04-09-07-02-05
"mozilla-central" revision="b1fb34b07c17"
"integration/gaia-central" revision="3d5b037cb2fd"
"gecko.git" revision="abcb3ee7673379f301335ba174967312abf984ba"
"gaia.git" revision="65dd37c938b1cd38fce96fcfa7f4be09e259c255"
Unagi

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 574c7770ba7e554821cfaa3c7e5f383443269063 as:
v1-train: 72d38feb7cb4731cce0bcc4e10ed303a6dc1a07a

Comment 16

[Axel Hecht [:Pike]]

This changed 

     1.7 -setup-progress-wait=Please wait while your account is set up
     1.8 +setup-progress-wait=Setting up account

without changing the string ID.

This isn't going to be exposed to l10n without that.

Comment 17

[Eric Pang [:epang] UX]

(In reply to Axel Hecht [:Pike] from comment #16)
> This changed 
> 
>      1.7 -setup-progress-wait=Please wait while your account is set up
>      1.8 +setup-progress-wait=Setting up account
> 
> without changing the string ID.
> 
> This isn't going to be exposed to l10n without that.

Hi Axel, what can we do to fix this?

Comment 18

[Axel Hecht [:Pike]]

It will need a follow-up patch to change the id for the string.

Comment 19

[Eric Pang [:epang] UX]

(In reply to Axel Hecht [:Pike] from comment #18)
> It will need a follow-up patch to change the id for the string.

Thanks Axel!  Pavel can you please look into this?  Thanks!

Comment 20

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: follow-up patch

Hey Axel,
thanks for the info ... I'm not familiar with string changes ... so is this patch is ok?
thanks again :)

Comment 21

[Axel Hecht [:Pike]]

Comment on attachment 737889 [details]
follow-up patch

The .properties should only have the new string with the new ID. Commented in the PR, too.

Comment 22

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

PR updated. Thanks Axel :)

Comment 23

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #22)
> PR updated. Thanks Axel :)

Pavel, who can review this PR? Sam?

Comment 24

[Axel Hecht [:Pike]]

Comment on attachment 737889 [details]
follow-up patch

Yep, like this, thanks.

Comment 25

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)