845121 - Calendar - Delete account screen layout update

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Eric Pang [:epang] UX]

Attachment: Calendar - Delete account screen mock up

See image attachment for detailed changes.

Comment 1

[Eric Pang [:epang] UX]

Part of LG's request for font updates.

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia repo

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

we need Bug 845115 first for (layout adjustment)

Comment 6

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #3)
> Created attachment 728748 [details]
> After patch

Thanks Pavel, this will be good once Bug 845115 fixes the layout.

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 728749 [details]
patch for Gaia repo

Hi Pavel - Please rebase the merge, and mark me as reviewer again once that's done. Also - please be sure that the delete button for events is affected as intended. It also has a role="button".

Thanks!

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 728749 [details]
patch for Gaia repo

Looks good, thanks!

Comment 9

[Kevin Grandon :kgrandon]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/d5ea52bd63855f47219579bcbaf8970677821582

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified:
Master build : 2013-04-05-03-05-43
name="mozilla-central" revision="55f9e3e3dae7"  
name="integration/gaia-central" revision="2005e026bdae"
"gecko.git" revision="66b64f47a4eac1bd4f5ea6748b42ddf732297550"
"gaia.git" revision="15468abcba0dd2549f0c102df887a5c049b9c641"
Unagi

Comment 11

[Ismael Gonzalez [:basiclines]]

Comment on attachment 728749 [details]
patch for Gaia repo

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: It will seem that the UI is broken for the missing space.
Testing completed: 
Risk to taking this patch (and alternatives if risky): Low risk, just css changes to adjust some margins
String or UUID changes made by this patch:

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 d5ea52bd63855f47219579bcbaf8970677821582
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 13

[Eric Pang [:epang] UX]

Sam/Pavel, can you look into this? Thanks!

Comment 14

[Kevin Grandon :kgrandon]

This has landed in v1-train: https://github.com/mozilla-b2g/gaia/commit/a10354aafa01f405cad9097195659e9581e959c9