845277 - Asan builds burning with "js/src/jsproxy.h:346:7: error: visibility does not match previous declaration"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ed Morley [:emorley]]

Started on this push:
https://tbpl.mozilla.org/?noignore=1&rev=f9ece777368e

{
In file included from /builds/slave/m-cen-l64-dbg-asan-00000000000/build/js/src/jsobjinlines.h:22:
/builds/slave/m-cen-l64-dbg-asan-00000000000/build/js/src/jsproxy.h:346:7: error: visibility does not match previous declaration
class JS_FRIEND_API(AutoEnterPolicy)
}

Comment 1

[Ed Morley [:emorley]]

decoder: The first bad revision is:
decoder: changeset:   122943:51483e470216
decoder: user:        Bobby Holley <bobbyholley@snip>
decoder: date:        Mon Feb 25 13:54:18 2013 -0800
decoder: summary:     Bug 836301 - Hoist some assertions, remove a bunch of no-op trap overrides, and add assertions that we've entered our policy. r=mrbkap

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

The clang used is 170890.

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

(In reply to Rafael Ávila de Espíndola (:espindola) from comment #2)
> The clang used is 170890.

Which is the one we had been using. I thought this could be a bug in newer clangs, but was change in m-c.

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

Comment 5

[Jan de Mooij [:jandem]]

See also bug 845215.

Comment 6

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/a2e147b93af6

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a2e147b93af6